* Re: [PATCH] CHROMIUM: acerhdf: fix bug when running on Qemu [not found] <1273122377-12137-1-git-send-email-rkc@chromium.org> @ 2010-05-06 5:41 ` peter 2010-05-06 5:44 ` Rahul Chaturvedi 1 sibling, 0 replies; 4+ messages in thread From: peter @ 2010-05-06 5:41 UTC (permalink / raw) To: Rahul Chaturvedi; +Cc: linux-kernel, msb Quoting Rahul Chaturvedi <rkc@chromium.org>: > Driver didn't verify the pointers in which it got product information > back from DMI; on QEMU one of the pointers came back null, > which made the driver crash and subsequently caused a kernel panic. > > Signed-off-by: Rahul Chaturvedi <rkc@chromium.org> > --- > drivers/platform/x86/acerhdf.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c > index 4d922e4..e8ee3b2 100644 > --- a/drivers/platform/x86/acerhdf.c > +++ b/drivers/platform/x86/acerhdf.c > @@ -500,6 +500,11 @@ static int acerhdf_check_hardware(void) > product = dmi_get_system_info(DMI_PRODUCT_NAME); > > > + if (!vendor || !version || !product) { > + pr_err("error getting hardware information"); > + return -EINVAL; > + } > + > pr_info("Acer Aspire One Fan driver, v.%s\n", DRV_VER); > > if (force_bios[0]) { > -- > 1.7.0.1 > > Acked-by: Peter Feuerer <peter@piie.net> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] CHROMIUM: acerhdf: fix bug when running on Qemu [not found] <1273122377-12137-1-git-send-email-rkc@chromium.org> 2010-05-06 5:41 ` [PATCH] CHROMIUM: acerhdf: fix bug when running on Qemu peter @ 2010-05-06 5:44 ` Rahul Chaturvedi 2010-05-06 20:08 ` Peter Feuerer 1 sibling, 1 reply; 4+ messages in thread From: Rahul Chaturvedi @ 2010-05-06 5:44 UTC (permalink / raw) To: peter, linux-kernel; +Cc: msb, Rahul Chaturvedi BTW, the CHROMIUM in the subject is just used for internal bookeeping for patches not yet accepted upstream. On Wed, May 5, 2010 at 22:06, Rahul Chaturvedi <rkc@chromium.org> wrote: > Driver didn't verify the pointers in which it got product information > back from DMI; on QEMU one of the pointers came back null, > which made the driver crash and subsequently caused a kernel panic. > > Signed-off-by: Rahul Chaturvedi <rkc@chromium.org> > --- > drivers/platform/x86/acerhdf.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c > index 4d922e4..e8ee3b2 100644 > --- a/drivers/platform/x86/acerhdf.c > +++ b/drivers/platform/x86/acerhdf.c > @@ -500,6 +500,11 @@ static int acerhdf_check_hardware(void) > product = dmi_get_system_info(DMI_PRODUCT_NAME); > > > + if (!vendor || !version || !product) { > + pr_err("error getting hardware information"); > + return -EINVAL; > + } > + > pr_info("Acer Aspire One Fan driver, v.%s\n", DRV_VER); > > if (force_bios[0]) { > -- > 1.7.0.1 > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] CHROMIUM: acerhdf: fix bug when running on Qemu 2010-05-06 5:44 ` Rahul Chaturvedi @ 2010-05-06 20:08 ` Peter Feuerer 2010-05-06 20:49 ` Mandeep Singh Baines 0 siblings, 1 reply; 4+ messages in thread From: Peter Feuerer @ 2010-05-06 20:08 UTC (permalink / raw) To: Rahul Chaturvedi; +Cc: linux-kernel, msb Rahul Chaturvedi writes: > BTW, the CHROMIUM in the subject is just used for internal bookeeping > for patches not yet accepted upstream. What does it mean? Should I take care about getting it upstream? --peter; ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] CHROMIUM: acerhdf: fix bug when running on Qemu 2010-05-06 20:08 ` Peter Feuerer @ 2010-05-06 20:49 ` Mandeep Singh Baines 0 siblings, 0 replies; 4+ messages in thread From: Mandeep Singh Baines @ 2010-05-06 20:49 UTC (permalink / raw) To: Peter Feuerer; +Cc: Rahul Chaturvedi, linux-kernel, msb Peter Feuerer (pfe@piie.net) wrote: > Rahul Chaturvedi writes: > >> BTW, the CHROMIUM in the subject is just used for internal bookeeping >> for patches not yet accepted upstream. > > What does it mean? Should I take care about getting it upstream? > You can drop it. We use it for internal bookkeeping in the chromium git tree. http://chromiumos-git/?p=kernel.git Its useful to us when we rebase our kernel to a new 2.6.x. We use it to record which tree the patch came from: did it come from upstream, did we write, did we pull it from a maintainer tree. > --peter; ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-05-06 20:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1273122377-12137-1-git-send-email-rkc@chromium.org>
2010-05-06 5:41 ` [PATCH] CHROMIUM: acerhdf: fix bug when running on Qemu peter
2010-05-06 5:44 ` Rahul Chaturvedi
2010-05-06 20:08 ` Peter Feuerer
2010-05-06 20:49 ` Mandeep Singh Baines
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox