From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755137Ab0EGLVK (ORCPT ); Fri, 7 May 2010 07:21:10 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:57831 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754113Ab0EGLVI (ORCPT ); Fri, 7 May 2010 07:21:08 -0400 Date: Fri, 7 May 2010 12:21:03 +0100 From: Mark Brown To: Arve =?iso-8859-1?B?SGr4bm5lduVn?= Cc: Brian Swetland , Alan Stern , Matthew Garrett , "Rafael J. Wysocki" , Kevin Hilman , linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Tejun Heo , Oleg Nesterov , Paul Walmsley , magnus.damm@gmail.com, mark gross , Arjan van de Ven , Geoff Smith , rebecca@android.com Subject: Re: [PATCH 0/8] Suspend block api (version 6) Message-ID: <20100507112102.GC21498@rakim.wolfsonmicro.main> References: <20100505185225.GA4411@srcf.ucam.org> <20100505234025.GB4838@opensource.wolfsonmicro.com> <20100507100406.GA21498@rakim.wolfsonmicro.main> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Cookie: Exercise caution in your daily affairs. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 07, 2010 at 03:57:37AM -0700, Arve Hjønnevåg wrote: > 2010/5/7 Mark Brown : > > As discussed elsewhere in the thread a suspend blocker is not desirable > > here - the AP is not doing anything useful on a voice call so blocking > > the suspend will just waste power unless runtime PM is good enough to > > mean opportunistic suspend isn't adding anything anyway.  It will avoid > > the immediate issue with loosing audio but it's not really what we want > > to happen. > I was talking about audio from the AP. Why would you ever turn off > another core's audio path on suspend? This goes back to the thing about a full system suspend being a sledgehammer which doesn't give enough information about what's going on when it's used like this. As discussed we need a way to know that the connections involved are able to stay live during suspend (on a large proportion of systems suspend is going to mean that the relevant bits of the board will loose power so need to be shut down) and that that the intention of the user is that they should do so (this isn't clear in the general system, especially not if the suspend is initiated manually). With a runtime PM approach this is trivial - we just turn off anything that isn't in use at the current time. I'll need to extend ASoC to add information about what to do on suspend to the existing power data.