public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ali Gholami Rudi <ali@rudi.ir>
To: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	dfeng@redhat.com, x86@kernel.org, venki@google.com,
	tglx@linutronix.de, suresh.b.siddha@intel.com, mingo@redhat.com,
	linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [regression] commit 6a4f3b52 causes invalid memtype
Date: Mon, 05 Jul 2010 11:38:14 +0000	[thread overview]
Message-ID: <20100507113814@tarekhel> (raw)
In-Reply-To: <20100705104035.GA28190@elte.hu>

Ingo Molnar <mingo@elte.hu> wrote:
> > > >> commit 2463eb8b3093995e09a0d41b3d78ee0cf5fb4249
> > > >> Author: Peter Zijlstra<peterz@infradead.org>
> > > >> Date:   Sat May 29 15:31:43 2010 +0200
> > > >>
> > > >>       rbtree: Undo augmented trees performance damage
> > > >
> > > > Where can I get it?  I couldn't find it either in
> > > > Linus' or x86 repo tip.
> > > http://git.kernel.org/tip/2463eb8b3093995e09a0d41b3d78ee0cf5fb4249
> > 
> > It does fix it.
> 
> Hm, interesting. That's a pure performance fix - so why does it fix a 
> regression?
> 
> Does Peter's augmented rbtrees improvements fix a bug too, as a side-effect? 
> If yes then we need to accelerate that commit - right now it's aimed for 
> v2.6.36.

Since the bug appears after commit 6a4f3b52, it seems to be
related to the value of memtype->subtree_max_end.  Peter's
patch seems to change the way memtype->subtree_max_end is
updated, which seems to fix the problem too.

Thanks,
Ali


  reply	other threads:[~2010-07-05 11:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-05  7:51 [regression] commit 6a4f3b52 causes invalid memtype Ali Gholami Rudi
2010-07-05  8:52 ` Xiaotian Feng
2010-07-05  9:28   ` Ali Gholami Rudi
2010-07-05  9:36     ` Xiaotian Feng
2010-07-05  9:57       ` Ali Gholami Rudi
2010-07-05 10:40         ` Ingo Molnar
2010-07-05 11:38           ` Ali Gholami Rudi [this message]
2010-07-05 12:45             ` Ingo Molnar
2010-07-06  2:26             ` Xiaotian Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100507113814@tarekhel \
    --to=ali@rudi.ir \
    --cc=a.p.zijlstra@chello.nl \
    --cc=dfeng@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=venki@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox