From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758641Ab0EGVgL (ORCPT ); Fri, 7 May 2010 17:36:11 -0400 Received: from cavan.codon.org.uk ([93.93.128.6]:36629 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756436Ab0EGVgI (ORCPT ); Fri, 7 May 2010 17:36:08 -0400 Date: Fri, 7 May 2010 22:36:00 +0100 From: Matthew Garrett To: Linus Torvalds Cc: Len Brown , Linux Kernel Mailing List , linux-acpi@vger.kernel.org, Andrew Morton Subject: Re: [git pull request] ACPI patches for 2.6.34-rc6 Message-ID: <20100507213600.GC28906@srcf.ucam.org> References: <20100507061203.GA8779@srcf.ucam.org> <20100507211331.GA28906@srcf.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 07, 2010 at 02:21:08PM -0700, Linus Torvalds wrote: > On Fri, 7 May 2010, Matthew Garrett wrote: > > > On Fri, May 07, 2010 at 02:06:53PM -0700, Linus Torvalds wrote: > > > On Fri, 7 May 2010, Matthew Garrett wrote: > > > > > > > > The spec says we can't. I've posted a patch to do so if it's still not > > > > set after we've tried doing it the right way, but I'm not keen on > > > > pushing it into a release at this point. > > > > > > I'm ok with the "release at this point". > > > > http://git.kernel.org/?p=linux/kernel/git/lenb/linux-acpi-2.6.git;a=commit;h=3b12303e6bda6e05579d899fb71cb3e9d3bc26ba > > Well, is there any reason to have 'set_sci_en_on_resume' at all then? I'd hope not, but it depends on what Windows does on resume. If it doesn't do the SMM call and just does the register write instead, then it may be that some machines are on that list because the SMM call breaks them rather than because they need the register to be set by hand. I'm planning on instrumenting it to check, but haven't had time to do so yet. -- Matthew Garrett | mjg59@srcf.ucam.org