From: Dan Carpenter <error27@gmail.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Benny Halevy <bhalevy@panasas.com>,
Avishay Traeger <avishay@gmail.com>,
osd-dev@open-osd.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] exofs: confusion between kmap() and kmap_atomic() api
Date: Mon, 10 May 2010 18:15:29 +0200 [thread overview]
Message-ID: <20100510161528.GX27064@bicker> (raw)
In-Reply-To: <4BE68B86.50707@panasas.com>
On Sun, May 09, 2010 at 01:16:38PM +0300, Boaz Harrosh wrote:
> On 05/07/2010 12:05 PM, Dan Carpenter wrote:
> > For kmap_atomic() we call kunmap_atomic() on the returned pointer.
> > That's different from kmap() and kunmap() and so it's easy to get them
> > backwards.
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
> >
>
> Thank you Dan, I'll push it ASAP.
>
> Looks like a bad bug. So this is actually a leak, right? kunmap_atomic
> would detect the bad pointer and do nothing?
>
I've looked at it, and I think you're right but I'm not the guy to ask...
I saw somenoe else fixing these and wrote a smatch check is all. I'm at
the "Monkey see, monkey do" level of kernel hacking.
regards,
dan carpenter
next prev parent reply other threads:[~2010-05-10 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 9:05 [patch] exofs: confusion between kmap() and kmap_atomic() api Dan Carpenter
2010-05-09 10:16 ` Boaz Harrosh
2010-05-10 16:15 ` Dan Carpenter [this message]
2010-05-10 23:03 ` Andrew Morton
2010-05-11 8:05 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100510161528.GX27064@bicker \
--to=error27@gmail.com \
--cc=avishay@gmail.com \
--cc=bhalevy@panasas.com \
--cc=bharrosh@panasas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=osd-dev@open-osd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox