From: Masami Hiramatsu <mhiramat@redhat.com>
To: Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>
Cc: systemtap <systemtap@sources.redhat.com>,
DLE <dle-develop@lists.sourceforge.net>,
Masami Hiramatsu <mhiramat@redhat.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Ingo Molnar <mingo@elte.hu>, Jim Keniston <jkenisto@us.ibm.com>,
Jason Baron <jbaron@redhat.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: [PATCH -tip 1/5] [CLEANUP] kprobes: Remove redundant text_mutex lock in optimize
Date: Mon, 10 May 2010 13:53:20 -0400 [thread overview]
Message-ID: <20100510175320.27396.49896.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20100510175313.27396.34605.stgit@localhost6.localdomain6>
Remove text_mutex locking in optimize_all_kprobes, because
that function doesn't modify text but just order optimization
to worker.
Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Jim Keniston <jkenisto@us.ibm.com>
Cc: Jason Baron <jbaron@redhat.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---
kernel/kprobes.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index 282035f..1d34eef 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -606,14 +606,12 @@ static void __kprobes optimize_all_kprobes(void)
return;
kprobes_allow_optimization = true;
- mutex_lock(&text_mutex);
for (i = 0; i < KPROBE_TABLE_SIZE; i++) {
head = &kprobe_table[i];
hlist_for_each_entry_rcu(p, node, head, hlist)
if (!kprobe_disabled(p))
optimize_kprobe(p);
}
- mutex_unlock(&text_mutex);
printk(KERN_INFO "Kprobes globally optimized\n");
}
--
Masami Hiramatsu
e-mail: mhiramat@redhat.com
next prev parent reply other threads:[~2010-05-10 17:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 17:53 [PATCH -tip 0/5] kprobes: batch (un)optimization support Masami Hiramatsu
2010-05-10 17:53 ` Masami Hiramatsu [this message]
2010-05-11 12:35 ` [PATCH -tip 1/5] [CLEANUP] kprobes: Remove redundant text_mutex lock in optimize Mathieu Desnoyers
2010-05-11 20:06 ` Masami Hiramatsu
2010-05-10 17:53 ` [PATCH -tip 2/5] kprobes: Limit maximum number of optimization at once Masami Hiramatsu
2010-05-10 17:53 ` [PATCH -tip 3/5] x86: Introduce text_poke_smp_batch() for batch-code modifying Masami Hiramatsu
2010-05-10 17:53 ` [PATCH -tip 4/5] kprobes/x86: Use text_poke_smp_batch Masami Hiramatsu
2010-05-11 14:40 ` Mathieu Desnoyers
2010-05-12 0:41 ` Masami Hiramatsu
2010-05-12 15:27 ` Mathieu Desnoyers
2010-05-12 17:43 ` Masami Hiramatsu
2010-05-12 17:48 ` Mathieu Desnoyers
2010-05-12 19:11 ` Masami Hiramatsu
2010-05-13 19:07 ` Masami Hiramatsu
2010-05-13 21:20 ` Mathieu Desnoyers
2010-05-10 17:53 ` [PATCH -tip 5/5] kprobes: Support delayed unoptimization Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100510175320.27396.49896.stgit@localhost6.localdomain6 \
--to=mhiramat@redhat.com \
--cc=ananth@in.ibm.com \
--cc=dle-develop@lists.sourceforge.net \
--cc=jbaron@redhat.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).