From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
albert_herranz@yahoo.es, linux@eikelenboom.it,
chrisw@sous-sol.org, Ian.Campbell@eu.citrix.com, jeremy@goop.org,
dwmw2@infradead.org, alex.williamson@hp.com
Subject: Re: [PATCH 2/6] swiotlb: swiotlb_tbl_map_single: abstract out swiotlb_virt_to_bus calls out.
Date: Mon, 10 May 2010 15:31:18 -0400 [thread overview]
Message-ID: <20100510193118.GA5906@phenom.dumpdata.com> (raw)
In-Reply-To: <20100509223623X.fujita.tomonori@lab.ntt.co.jp>
On Sun, May 09, 2010 at 10:41:15PM +0900, FUJITA Tomonori wrote:
> On Wed, 7 Apr 2010 16:29:26 -0400
> Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
>
> > We want to move that function out of swiotlb_tbl_map_single so that the caller
> > of this function does the virt->phys->bus address translation.
> >
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > ---
> > lib/swiotlb.c | 22 ++++++++++++++--------
> > 1 files changed, 14 insertions(+), 8 deletions(-)
>
> It would be better to do something like that instead of spreading
> swiotlb_virt_to_bus()?
Yes! Thought I am confused by the name. In the past you mentioned 'tbl',
but here it is 'tlb'. I presume 'tbl' is the right one?
> Subject: [PATCH] swiotlb: add swiotlb_tlb_map_single library function
>
> swiotlb_tlb_map_single() takes the dma address of iotlb instead of
> using swiotlb_virt_to_bus().
next prev parent reply other threads:[~2010-05-10 19:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 20:29 [PATCH] swiotlb 0.7: separation of physical and virtual address translation Konrad Rzeszutek Wilk
2010-04-07 20:29 ` [PATCH 1/6] swiotlb: Make internal bookkeeping functions have 'swiotlb_tbl' prefix Konrad Rzeszutek Wilk
2010-04-07 20:29 ` [PATCH 2/6] swiotlb: swiotlb_tbl_map_single: abstract out swiotlb_virt_to_bus calls out Konrad Rzeszutek Wilk
2010-04-07 20:29 ` [PATCH 3/6] swiotlb: Make exportable bookkeeping functions and variables have same prefix Konrad Rzeszutek Wilk
2010-04-07 20:29 ` [PATCH 4/6] swiotlb: search and replace "int dir" with "enum dma_data_direction dir" Konrad Rzeszutek Wilk
2010-04-07 20:29 ` [PATCH 5/6] swiotlb: Make swiotlb bookkeeping functions visible in the header file Konrad Rzeszutek Wilk
2010-04-07 20:29 ` [PATCH 6/6] swiotlb: EXPORT_SYMBOL_GPL functions + variables that are defined " Konrad Rzeszutek Wilk
2010-05-09 13:41 ` [PATCH 5/6] swiotlb: Make swiotlb bookkeeping functions visible " FUJITA Tomonori
2010-05-10 19:35 ` Konrad Rzeszutek Wilk
2010-05-09 13:41 ` [PATCH 3/6] swiotlb: Make exportable bookkeeping functions and variables have same prefix FUJITA Tomonori
2010-05-10 19:33 ` Konrad Rzeszutek Wilk
2010-05-11 1:56 ` FUJITA Tomonori
2010-05-09 13:41 ` [PATCH 2/6] swiotlb: swiotlb_tbl_map_single: abstract out swiotlb_virt_to_bus calls out FUJITA Tomonori
2010-05-10 19:31 ` Konrad Rzeszutek Wilk [this message]
2010-05-11 1:56 ` FUJITA Tomonori
2010-05-04 16:41 ` [LKML] [PATCH] swiotlb 0.7: separation of physical and virtual address translation Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100510193118.GA5906@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=albert_herranz@yahoo.es \
--cc=alex.williamson@hp.com \
--cc=chrisw@sous-sol.org \
--cc=dwmw2@infradead.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=iommu@lists.linux-foundation.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@eikelenboom.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).