linux-next: build warnings after merge of the rr tree

linux-next: build warnings after merge of the rr tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2602 bytes --]

Hi Rusty,

After merging the fsnotify tree, today's linux-next build (x86_64 allmodconfig)
produced thes warnings:

drivers/acpi/debug.c:140: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/acpi/debug.c:140: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/acpi/debug.c:140: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/acpi/debug.c:140: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/acpi/debug.c:141: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/acpi/debug.c:141: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/acpi/debug.c:141: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/acpi/debug.c:141: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'

Introduced by commit a1c3b92923eced4ee034fa15bf058f91e435e08c ("param:param_ops").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build warnings after merge of the rr tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1790 bytes --]

Hi Rusty,

On Mon, 10 May 2010 13:44:09 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> drivers/acpi/debug.c:141: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> 
> Introduced by commit a1c3b92923eced4ee034fa15bf058f91e435e08c ("param:param_ops").

Also

drivers/message/fusion/mptbase.c:112: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/message/fusion/mptbase.c:112: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/message/fusion/mptbase.c:112: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/message/fusion/mptbase.c:112: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build warnings after merge of the rr tree

[Rusty Russell]

On Mon, 10 May 2010 01:16:20 pm Stephen Rothwell wrote:
> Hi Rusty,
> 
> On Mon, 10 May 2010 13:44:09 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > drivers/acpi/debug.c:141: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> > include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> > 
> > Introduced by commit a1c3b92923eced4ee034fa15bf058f91e435e08c ("param:param_ops").
> 
> Also
> 
> drivers/message/fusion/mptbase.c:112: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'

Thanks, these are harmless, and I had followup patches outside linux-next
which resolve them.

I've now included them in the linux-next part of the series.

Thanks,
Rusty.

Re: linux-next: build warnings after merge of the rr tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

Hi Rusty,

On Mon, 10 May 2010 22:03:53 +0930 Rusty Russell <rusty@rustcorp.com.au> wrote:
>
> Thanks, these are harmless, and I had followup patches outside linux-next
> which resolve them.
> 
> I've now included them in the linux-next part of the series.

Excellent, thanks.  The problem with "harmless" warnings is that they
make the important warnings harder to spot. :-(

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

linux-next: build warnings after merge of the rr tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]

Hi Rusty,

After merging the rr tree, today's linux-next build (x86_64 allmodconfig)
produced these warnings:

security/apparmor/lsm.c: In function '__check_debug':
security/apparmor/lsm.c:712:1: warning: return from incompatible pointer type [enabled by default]
security/apparmor/lsm.c: In function '__check_audit_header':
security/apparmor/lsm.c:724:1: warning: return from incompatible pointer type [enabled by default]
security/apparmor/lsm.c: In function '__check_lock_policy':
security/apparmor/lsm.c:732:1: warning: return from incompatible pointer type [enabled by default]
security/apparmor/lsm.c: In function '__check_logsyscall':
security/apparmor/lsm.c:736:1: warning: return from incompatible pointer type [enabled by default]
security/apparmor/lsm.c: In function '__check_paranoid_load':
security/apparmor/lsm.c:747:1: warning: return from incompatible pointer type [enabled by default]
security/apparmor/lsm.c: In function '__check_enabled':
security/apparmor/lsm.c:751:1: warning: return from incompatible pointer type [enabled by default]

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warnings after merge of the rr tree

[Rusty Russell]

On Wed, 28 Dec 2011 13:58:17 +1100, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
Non-text part: multipart/signed
> Hi Rusty,
> 
> After merging the rr tree, today's linux-next build (x86_64 allmodconfig)
> produced these warnings:
> 
> security/apparmor/lsm.c: In function '__check_debug':
> security/apparmor/lsm.c:712:1: warning: return from incompatible pointer type [enabled by default]
> security/apparmor/lsm.c: In function '__check_audit_header':
> security/apparmor/lsm.c:724:1: warning: return from incompatible pointer type [enabled by default]
> security/apparmor/lsm.c: In function '__check_lock_policy':
> security/apparmor/lsm.c:732:1: warning: return from incompatible pointer type [enabled by default]
> security/apparmor/lsm.c: In function '__check_logsyscall':
> security/apparmor/lsm.c:736:1: warning: return from incompatible pointer type [enabled by default]
> security/apparmor/lsm.c: In function '__check_paranoid_load':
> security/apparmor/lsm.c:747:1: warning: return from incompatible pointer type [enabled by default]
> security/apparmor/lsm.c: In function '__check_enabled':
> security/apparmor/lsm.c:751:1: warning: return from incompatible pointer type [enabled by default]

Hmm, I thought the lsm guys had taken the patch for that.

James said he'd applied it.  Repeated below...

From: Rusty Russell <rusty@rustcorp.com.au>
Subject: apparmor: fix module parameter handling

The 'aabool' wrappers actually pass off to the 'bool' parse functions,
so you should use the same check function.  Similarly for aauint and
uint.

(Note that 'bool' module parameters also allow 'int', which is why you
got away with this, but that's changing very soon.)

Cc: John Johansen <john.johansen@canonical.com>
Cc: James Morris <jmorris@namei.org>
Cc: linux-security-module@vger.kernel.org
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
 security/apparmor/lsm.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
--- a/security/apparmor/lsm.c
+++ b/security/apparmor/lsm.c
@@ -671,7 +671,7 @@ static struct security_operations apparm
 
 static int param_set_aabool(const char *val, const struct kernel_param *kp);
 static int param_get_aabool(char *buffer, const struct kernel_param *kp);
-#define param_check_aabool(name, p) __param_check(name, p, int)
+#define param_check_aabool param_check_bool
 static struct kernel_param_ops param_ops_aabool = {
 	.set = param_set_aabool,
 	.get = param_get_aabool
@@ -679,7 +679,7 @@ static struct kernel_param_ops param_ops
 
 static int param_set_aauint(const char *val, const struct kernel_param *kp);
 static int param_get_aauint(char *buffer, const struct kernel_param *kp);
-#define param_check_aauint(name, p) __param_check(name, p, int)
+#define param_check_aauint param_check_uint
 static struct kernel_param_ops param_ops_aauint = {
 	.set = param_set_aauint,
 	.get = param_get_aauint
@@ -687,7 +687,7 @@ static struct kernel_param_ops param_ops
 
 static int param_set_aalockpolicy(const char *val, const struct kernel_param *kp);
 static int param_get_aalockpolicy(char *buffer, const struct kernel_param *kp);
-#define param_check_aalockpolicy(name, p) __param_check(name, p, int)
+#define param_check_aalockpolicy param_check_bool
 static struct kernel_param_ops param_ops_aalockpolicy = {
 	.set = param_set_aalockpolicy,
 	.get = param_get_aalockpolicy

Re: linux-next: build warnings after merge of the rr tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1826 bytes --]

Hi Rusty,

On Thu, 29 Dec 2011 13:46:36 +1030 Rusty Russell <rusty@rustcorp.com.au> wrote:
>
> On Wed, 28 Dec 2011 13:58:17 +1100, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > 
> > After merging the rr tree, today's linux-next build (x86_64 allmodconfig)
> > produced these warnings:
> > 
> > security/apparmor/lsm.c: In function '__check_debug':
> > security/apparmor/lsm.c:712:1: warning: return from incompatible pointer type [enabled by default]
> > security/apparmor/lsm.c: In function '__check_audit_header':
> > security/apparmor/lsm.c:724:1: warning: return from incompatible pointer type [enabled by default]
> > security/apparmor/lsm.c: In function '__check_lock_policy':
> > security/apparmor/lsm.c:732:1: warning: return from incompatible pointer type [enabled by default]
> > security/apparmor/lsm.c: In function '__check_logsyscall':
> > security/apparmor/lsm.c:736:1: warning: return from incompatible pointer type [enabled by default]
> > security/apparmor/lsm.c: In function '__check_paranoid_load':
> > security/apparmor/lsm.c:747:1: warning: return from incompatible pointer type [enabled by default]
> > security/apparmor/lsm.c: In function '__check_enabled':
> > security/apparmor/lsm.c:751:1: warning: return from incompatible pointer type [enabled by default]
> 
> Hmm, I thought the lsm guys had taken the patch for that.
> 
> James said he'd applied it.  Repeated below...
> 
> From: Rusty Russell <rusty@rustcorp.com.au>
> Subject: apparmor: fix module parameter handling

Indeed it has been applied.  Unfortunately, I merge the rr tree before
the security tree, so that warning appears between the two merges.   I
will ignore it.

Sorry for the noise.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]