From: Oliver Neukum <oneukum@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Eric Piel <eric.piel@tremplin-utc.net>,
Pavel Machek <pavel@ucw.cz>,
Pavel Herrmann <morpheus.ibis@gmail.com>,
lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org,
stable@kernel.org
Subject: Re: [patch]hp_accel: Fix race in device removal
Date: Tue, 11 May 2010 08:04:45 +0200 [thread overview]
Message-ID: <201005110804.45251.oneukum@suse.de> (raw)
In-Reply-To: <20100510225725.6bfdc4a5.akpm@linux-foundation.org>
Am Dienstag, 11. Mai 2010 04:57:25 schrieb Andrew Morton:
> On Tue, 11 May 2010 07:55:07 +0200 Oliver Neukum <oneukum@suse.de> wrote:
>
> > Am Dienstag, 11. Mai 2010 00:46:32 schrieb Andrew Morton:
> > > But alas, I (and presumably others) cannot confirm that, because you
> > > didn't describe the bug :( This also means that if someone hits a
> > > problem with this driver, they won't easily be able to work out whether
> > > this patch will fix it.
> > >
> > >
> > > Under what circumstances does it trigger?
> > >
> > > What are the observed effects when it triggers?
> > >
> > > Please always include this sort of information when sending bugfixes, thanks.
> >
> > Sorry,
> >
> > the patch closes a window during which a work queue might remain
> > active after the device is removed and would then lead to ACPI calls
> > with undefined behavior.
>
> Had anyone observed this in the field? Was a machine crashing, perhaps?
No, this was found during a code review.
Regards
Oliver
next prev parent reply other threads:[~2010-05-11 6:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 16:04 [patch]hp_accel: Fix race in device removal Oliver Neukum
2010-05-07 16:07 ` Pavel Machek
2010-05-07 16:09 ` Éric Piel
2010-05-10 22:46 ` Andrew Morton
2010-05-11 5:55 ` Oliver Neukum
2010-05-11 2:57 ` Andrew Morton
2010-05-11 6:04 ` Oliver Neukum [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-05-07 15:47 Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005110804.45251.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=akpm@linux-foundation.org \
--cc=eric.piel@tremplin-utc.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=morpheus.ibis@gmail.com \
--cc=pavel@ucw.cz \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox