From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757030Ab0EKNWA (ORCPT ); Tue, 11 May 2010 09:22:00 -0400 Received: from 0122700014.0.fullrate.dk ([95.166.99.235]:42869 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755428Ab0EKNV7 (ORCPT ); Tue, 11 May 2010 09:21:59 -0400 Date: Tue, 11 May 2010 15:21:57 +0200 From: Jens Axboe To: Mike Snitzer Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org, Kiyoshi Ueda , "Jun'ichi Nomura" , Vivek Goyal , Nikanth Karthikesan Subject: Re: [RFC PATCH 1/2] block: allow initialization of previously allocated request_queue Message-ID: <20100511132156.GX27497@kernel.dk> References: <1273532139-23043-1-git-send-email-snitzer@redhat.com> <20100511065520.GK27497@kernel.dk> <20100511131856.GB25211@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100511131856.GB25211@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 11 2010, Mike Snitzer wrote: > On Tue, May 11 2010 at 2:55am -0400, > Jens Axboe wrote: > > > On Mon, May 10 2010, Mike Snitzer wrote: > > > blk_init_queue() allocates the request_queue structure and then > > > initializes it as needed (request_fn, elevator, etc). > > > > > > Split initialization out to blk_init_allocated_queue_node. > > > Introduce blk_init_allocated_queue wrapper function to model existing > > > blk_init_queue and blk_init_queue_node interfaces. > > > > > > Export elv_register_queue to allow a newly added elevator to be > > > registered with sysfs. Export elv_unregister_queue for symmetry. > > > > > > These changes allow DM to initialize a device's request_queue with more > > > precision. In particular, DM no longer unconditionally initializes a > > > full request_queue (elevator et al). It only does so for a > > > request-based DM device. > > > > Looks good, I'll apply this. I don't think the exports need to be _GPL > > in this case, generally I've only done that with the exports for hooking > > in a new IO scheduler. > > OK, thanks for picking this up. Do you want me to send v2 that drops > the _GPL or will you make those changes? I just hand-edited that part. I can add the dm bit as well, when it has been reviewed and acked. -- Jens Axboe