From: Greg KH <gregkh@suse.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Michal Schmidt <mschmidt@redhat.com>,
linux-pci@vger.kernel.org,
Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: return correct value when writing to the "reset" attribute
Date: Tue, 11 May 2010 07:05:47 -0700 [thread overview]
Message-ID: <20100511140547.GA13575@suse.de> (raw)
In-Reply-To: <20100511105859.GA2295@redhat.com>
On Tue, May 11, 2010 at 01:58:59PM +0300, Michael S. Tsirkin wrote:
> On Tue, May 11, 2010 at 11:44:54AM +0200, Michal Schmidt wrote:
> > A successful write() to the "reset" sysfs attribute should return the
> > number of bytes written, not 0. Otherwise userspace (bash) retries the
> > write over and over again.
> >
> > Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
next prev parent reply other threads:[~2010-05-11 14:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 9:44 [PATCH] PCI: return correct value when writing to the "reset" attribute Michal Schmidt
2010-05-11 10:58 ` Michael S. Tsirkin
2010-05-11 14:05 ` Greg KH [this message]
2010-05-11 17:29 ` Jesse Barnes
[not found] <20100511093004.12167.9460.stgit@leela.lan>
2010-05-11 9:34 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100511140547.GA13575@suse.de \
--to=gregkh@suse.de \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mschmidt@redhat.com \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox