* [PATCH] PCI: return correct value when writing to the "reset" attribute
@ 2010-05-11 9:44 Michal Schmidt
2010-05-11 10:58 ` Michael S. Tsirkin
2010-05-11 17:29 ` Jesse Barnes
0 siblings, 2 replies; 5+ messages in thread
From: Michal Schmidt @ 2010-05-11 9:44 UTC (permalink / raw)
To: linux-pci
Cc: Michael S. Tsirkin, Jesse Barnes, Greg Kroah-Hartman,
linux-kernel
A successful write() to the "reset" sysfs attribute should return the
number of bytes written, not 0. Otherwise userspace (bash) retries the
write over and over again.
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
---
drivers/pci/pci-sysfs.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index fad9398..ba88a2f 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -960,7 +960,12 @@ static ssize_t reset_store(struct device *dev,
if (val != 1)
return -EINVAL;
- return pci_reset_function(pdev);
+
+ result = pci_reset_function(pdev);
+ if (result < 0)
+ return result;
+
+ return count;
}
static struct device_attribute reset_attr = __ATTR(reset, 0200, NULL, reset_store);
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] PCI: return correct value when writing to the "reset" attribute
2010-05-11 9:44 [PATCH] PCI: return correct value when writing to the "reset" attribute Michal Schmidt
@ 2010-05-11 10:58 ` Michael S. Tsirkin
2010-05-11 14:05 ` Greg KH
2010-05-11 17:29 ` Jesse Barnes
1 sibling, 1 reply; 5+ messages in thread
From: Michael S. Tsirkin @ 2010-05-11 10:58 UTC (permalink / raw)
To: Michal Schmidt; +Cc: linux-pci, Jesse Barnes, Greg Kroah-Hartman, linux-kernel
On Tue, May 11, 2010 at 11:44:54AM +0200, Michal Schmidt wrote:
> A successful write() to the "reset" sysfs attribute should return the
> number of bytes written, not 0. Otherwise userspace (bash) retries the
> write over and over again.
>
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> drivers/pci/pci-sysfs.c | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index fad9398..ba88a2f 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -960,7 +960,12 @@ static ssize_t reset_store(struct device *dev,
>
> if (val != 1)
> return -EINVAL;
> - return pci_reset_function(pdev);
> +
> + result = pci_reset_function(pdev);
> + if (result < 0)
> + return result;
> +
> + return count;
> }
>
> static struct device_attribute reset_attr = __ATTR(reset, 0200, NULL, reset_store);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PCI: return correct value when writing to the "reset" attribute
2010-05-11 10:58 ` Michael S. Tsirkin
@ 2010-05-11 14:05 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2010-05-11 14:05 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: Michal Schmidt, linux-pci, Jesse Barnes, linux-kernel
On Tue, May 11, 2010 at 01:58:59PM +0300, Michael S. Tsirkin wrote:
> On Tue, May 11, 2010 at 11:44:54AM +0200, Michal Schmidt wrote:
> > A successful write() to the "reset" sysfs attribute should return the
> > number of bytes written, not 0. Otherwise userspace (bash) retries the
> > write over and over again.
> >
> > Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PCI: return correct value when writing to the "reset" attribute
2010-05-11 9:44 [PATCH] PCI: return correct value when writing to the "reset" attribute Michal Schmidt
2010-05-11 10:58 ` Michael S. Tsirkin
@ 2010-05-11 17:29 ` Jesse Barnes
1 sibling, 0 replies; 5+ messages in thread
From: Jesse Barnes @ 2010-05-11 17:29 UTC (permalink / raw)
To: Michal Schmidt
Cc: linux-pci, Michael S. Tsirkin, Greg Kroah-Hartman, linux-kernel
On Tue, 11 May 2010 11:44:54 +0200
Michal Schmidt <mschmidt@redhat.com> wrote:
> A successful write() to the "reset" sysfs attribute should return the
> number of bytes written, not 0. Otherwise userspace (bash) retries the
> write over and over again.
>
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
> ---
>
> drivers/pci/pci-sysfs.c | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index fad9398..ba88a2f 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -960,7 +960,12 @@ static ssize_t reset_store(struct device *dev,
>
> if (val != 1)
> return -EINVAL;
> - return pci_reset_function(pdev);
> +
> + result = pci_reset_function(pdev);
> + if (result < 0)
> + return result;
> +
> + return count;
> }
>
> static struct device_attribute reset_attr = __ATTR(reset, 0200, NULL, reset_store);
Applied to my linux-next branch, thanks. I think it's probably too
late to get this into 2.6.34, but if it's affecting real users we can
try; otherwise you could get it into the stable tree.
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20100511093004.12167.9460.stgit@leela.lan>]
* Re: [PATCH] PCI: return correct value when writing to the "reset" attribute
[not found] <20100511093004.12167.9460.stgit@leela.lan>
@ 2010-05-11 9:34 ` Michael S. Tsirkin
0 siblings, 0 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2010-05-11 9:34 UTC (permalink / raw)
To: Michal Schmidt; +Cc: linux-pci, Jesse Barnes, linux-kernel, Greg Kroah-Hartman
On Tue, May 11, 2010 at 11:30:06AM +0200, Michal Schmidt wrote:
> A successful write() to the "reset" sysfs attribute should return the
> number of bytes written, not 0. Otherwise userspace (bash) retries the
> write over and over again.
>
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> drivers/pci/pci-sysfs.c | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index fad9398..ba88a2f 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -960,7 +960,12 @@ static ssize_t reset_store(struct device *dev,
>
> if (val != 1)
> return -EINVAL;
> - return pci_reset_function(pdev);
> +
> + result = pci_reset_function(pdev);
> + if (result < 0)
> + return result;
> +
> + return count;
> }
>
> static struct device_attribute reset_attr = __ATTR(reset, 0200, NULL, reset_store);
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-05-11 17:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-11 9:44 [PATCH] PCI: return correct value when writing to the "reset" attribute Michal Schmidt
2010-05-11 10:58 ` Michael S. Tsirkin
2010-05-11 14:05 ` Greg KH
2010-05-11 17:29 ` Jesse Barnes
[not found] <20100511093004.12167.9460.stgit@leela.lan>
2010-05-11 9:34 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox