From: Borislav Petkov <bp@amd64.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <peterz@infradead.org>,
Lin Ming <ming.m.lin@intel.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
"eranian@gmail.com" <eranian@gmail.com>,
"Gary.Mohr@Bull.com" <Gary.Mohr@bull.com>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
"arjan@linux.intel.com" <arjan@linux.intel.com>,
"Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
Paul Mackerras <paulus@samba.org>,
"David S. Miller" <davem@davemloft.net>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Paul Mundt <lethal@linux-sh.org>,
lkml <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [RFC][PATCH 3/9] perf: export registerred pmus via sysfs
Date: Tue, 11 May 2010 16:15:11 +0200 [thread overview]
Message-ID: <20100511141511.GA14034@aftab> (raw)
In-Reply-To: <20100510114311.GA6449@elte.hu>
From: Ingo Molnar <mingo@elte.hu>
Date: Mon, May 10, 2010 at 01:43:11PM +0200
Hi all,
> Yeah, we really want a mechanism like this in place instead of continuing with
> the somewhat ad-hoc extensions to the event enumeration space.
>
> One detail: i think we want one more level. Instead of:
>
> /sys/devices/system/node/nodeN/node_events
> node_events/event_source_id
> node_events/local_misses
> /local_hits
> /remote_misses
> /remote_hits
> /...
>
> We want the individual events to be a directory, containing the event_id:
>
> /sys/devices/system/node/nodeN/node_events
> node_events/event_source_id
> node_events/local_misses/event_id
> /local_hits/event_id
> /remote_misses/event_id
> /remote_hits/event_id
> /...
>
> The reason is that we want to keep our options open to add more attributes to
> individual events. (In fact extended attributes already exist for certain
> event classes - such as the 'format' info for tracepoints.)
ok, what you guys have so far sounds ok, here's some more stuff
we should be considering when using the tracepoints (and their
representation in /sysfs or whatever) for error reporting.
All the error reporting is done using MCEs so the
MCE should be a raw per cpu event somewhere under
/sys/devices/system/cpu/cpuN/events/raw_cpu_events/ or whatever works for
you.
Another point I have is that MCEs don't need pmus so we should consider
having the ability to decouple events from pmus.
What you basically want to have is a tracepoint which is "persistent,"
as Ingo suggested earlier, and it buffers MCEs occurring at any time
into a ring buffer until a userspace daemon or similar sucks that data
out for processing (critical stuff is handled differently, of course).
And this should work on any x86 hw supporting MCA without hw perf
monitoring features.
Also, we might think in terms of using some of the MCE fields in /sysfs
for hardware error injection like EDAC does inject DRAM ECC errors but
this should be straight-forward using one attribute like
/sys/devices/system/cpu/cpuN/events/raw_cpu_events/mce/inject_ecc
or similar.
This is mostly what I can come up with now...
--
Regards/Gruss,
Boris.
--
Advanced Micro Devices, Inc.
Operating Systems Research Center
next prev parent reply other threads:[~2010-05-11 14:14 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 9:27 [RFC][PATCH 3/9] perf: export registerred pmus via sysfs Lin Ming
2010-05-10 9:40 ` Peter Zijlstra
2010-05-10 10:11 ` Lin Ming
2010-05-10 10:18 ` Peter Zijlstra
2010-05-10 10:26 ` Lin Ming
2010-05-10 10:35 ` Paul Mundt
2010-05-10 10:58 ` Lin Ming
2010-05-10 11:04 ` Peter Zijlstra
2010-05-10 11:11 ` Lin Ming
2010-05-10 11:18 ` Lin Ming
2010-05-10 11:27 ` Peter Zijlstra
2010-05-10 11:36 ` Peter Zijlstra
2010-05-10 11:48 ` Ingo Molnar
2010-05-10 11:39 ` Russell King
2010-05-10 11:42 ` Peter Zijlstra
2010-05-10 20:25 ` Will Deacon
2010-05-11 6:34 ` Peter Zijlstra
2010-05-10 11:43 ` Ingo Molnar
2010-05-10 11:49 ` Peter Zijlstra
2010-05-10 11:53 ` Ingo Molnar
2010-05-10 23:13 ` Corey Ashford
2010-05-11 6:46 ` Peter Zijlstra
2010-05-11 7:21 ` Ingo Molnar
2010-05-11 8:20 ` Lin Ming
2010-05-11 8:50 ` Peter Zijlstra
2010-05-11 9:03 ` Lin Ming
2010-05-11 9:05 ` Lin Ming
2010-05-11 9:12 ` Peter Zijlstra
2010-05-11 9:18 ` Ingo Molnar
2010-05-11 9:24 ` Peter Zijlstra
2010-05-11 9:31 ` Ingo Molnar
2010-05-11 10:28 ` Lin Ming
2010-05-13 8:28 ` Lin Ming
2010-05-13 8:38 ` Ingo Molnar
2010-05-13 9:22 ` Lin Ming
2010-05-11 9:40 ` Lin Ming
2010-05-11 9:48 ` Peter Zijlstra
2010-05-11 9:53 ` Lin Ming
2010-05-11 15:17 ` Greg KH
2010-05-12 5:51 ` Paul Mundt
2010-05-12 8:37 ` Peter Zijlstra
2010-05-14 7:04 ` Paul Mundt
2010-05-11 10:09 ` stephane eranian
2010-05-11 14:15 ` Borislav Petkov [this message]
2010-05-11 14:25 ` Peter Zijlstra
2010-05-11 15:37 ` Borislav Petkov
2010-05-11 15:46 ` Peter Zijlstra
2010-05-10 23:54 ` Corey Ashford
2010-05-11 6:50 ` Peter Zijlstra
2010-05-11 2:43 ` Lin Ming
2010-05-11 6:35 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100511141511.GA14034@aftab \
--to=bp@amd64.org \
--cc=Gary.Mohr@bull.com \
--cc=acme@redhat.com \
--cc=arjan@linux.intel.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=fweisbec@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox