public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	mingo@elte.hu, "Paul Mackerras" <paulus@samba.org>,
	"David S. Miller" <davem@davemloft.net>,
	perfmon2-devel@lists.sf.net
Subject: Re: [RFC] perf: perf record sets inherit by default
Date: Tue, 11 May 2010 12:00:52 -0300	[thread overview]
Message-ID: <20100511150052.GE19192@ghostprotocols.net> (raw)
In-Reply-To: <AANLkTinsEANHEicdjOaE6jwUa0bVqH5PBwuGQ3_L59hT@mail.gmail.com>

Em Tue, May 11, 2010 at 04:04:17PM +0200, Stephane Eranian escreveu:
> I am confused by the inheritance cmd line option of perf record:

>  usage: perf record [<options>] [<command>]
>     or: perf record [<options>] -- <command> [<options>]
>     -p, --pid <n>         record events on existing process id
>     -t, --tid <n>         record events on existing thread id
>     -a, --all-cpus        system-wide collection from all CPUs
>     -C, --profile_cpu <n> CPU to profile on
>     -i, --inherit         child tasks inherit counters
 
> This leads to believe that by default inheritance in children is off.
 
> However, builtin-record.c says:
> static bool                     inherit    =   true;
 
> If that's the case, what's the point of the -i option?

Humm, since for -C and -a using -i doesn't make sense, I guess it should
be off by default and only be auto-activated if we don't specify any
option, i.e. when using it like:

perf record ./hackbench

What do you think?
 
> Another side effect of inheritance is that in per-thread mode, perf
> creates as many "sessions" as you have CPUs. So on a 16-way processor,
> sampling on cycles, perf creates 16 events and 16 x 2-page sampling
> buffers. That's a lot of resources consumed if I am just interested in
> monitoring a single-threaded workload.
 
> Am I missing something here?

I don't think so, but maybe I'm missing too :-)

- Arnaldo

  parent reply	other threads:[~2010-05-11 15:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-11 14:04 [RFC] perf: perf record sets inherit by default Stephane Eranian
2010-05-11 14:48 ` Peter Zijlstra
2010-05-17 14:25   ` Stephane Eranian
2010-05-17 16:48     ` Peter Zijlstra
2010-05-18 17:16       ` [tip:perf/core] perf: Optimize buffer placement by allocating buffers NUMA aware tip-bot for Peter Zijlstra
2010-05-11 15:00 ` Arnaldo Carvalho de Melo [this message]
2010-05-11 15:13   ` [RFC] perf: perf record sets inherit by default Peter Zijlstra
2010-05-11 15:17     ` Stephane Eranian
2010-05-11 15:50     ` Arnaldo Carvalho de Melo
2010-05-11 15:52       ` Peter Zijlstra
2010-05-11 15:55         ` Stephane Eranian
2010-05-11 15:59           ` Arnaldo Carvalho de Melo
2010-05-11 15:56         ` Arnaldo Carvalho de Melo
2010-05-11 16:01           ` Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100511150052.GE19192@ghostprotocols.net \
    --to=acme@infradead.org \
    --cc=davem@davemloft.net \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=perfmon2-devel@lists.sf.net \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox