From: Greg KH <greg@kroah.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Lin Ming <ming.m.lin@intel.com>, Ingo Molnar <mingo@elte.hu>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
"eranian@gmail.com" <eranian@gmail.com>,
"Gary.Mohr@Bull.com" <Gary.Mohr@bull.com>,
"arjan@linux.intel.com" <arjan@linux.intel.com>,
"Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
Paul Mackerras <paulus@samba.org>,
"David S. Miller" <davem@davemloft.net>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Paul Mundt <lethal@linux-sh.org>,
lkml <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Will Deacon <will.deacon@arm.com>,
Maynard Johnson <mpjohn@us.ibm.com>, Carl Love <carll@us.ibm.com>,
Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [RFC][PATCH 3/9] perf: export registerred pmus via sysfs
Date: Tue, 11 May 2010 08:17:47 -0700 [thread overview]
Message-ID: <20100511151747.GA16561@kroah.com> (raw)
In-Reply-To: <1273571322.5605.3523.camel@twins>
On Tue, May 11, 2010 at 11:48:42AM +0200, Peter Zijlstra wrote:
> On Tue, 2010-05-11 at 17:40 +0800, Lin Ming wrote:
> > /sys/devices/system/cpu/cpu0/cpu_hw_events/*
> > /sys/devices/system/cpu/cpu0/cpu_hw_cache_events/*
> > /sys/devices/system/cpu/cpu0/cpu_raw_events/*
> > ....
> > ....
> > /sys/devices/system/cpu/cpuN/cpu_hw_events/*
> > /sys/devices/system/cpu/cpuN/cpu_hw_cache_events/*
> > /sys/devices/system/cpu/cpuN/cpu_raw_events/*
> >
> > Is /sys/class/event_sources/* looks like,
> >
> > /sys/class/event_sources/cpu_hw_events0
> > -> /sys/devices/system/cpu/cpu0/cpu_hw_events
> > ...
> > /sys/class/event_sources/cpu_hw_eventsN
> > -> /sys/devices/system/cpu/cpuN/cpu_hw_events
> >
> > /sys/class/event_sources/cpu_hw_cache_events0
> > -> /sys/devices/system/cpu/cpu0/cpu_hw_events
> > ...
> > /sys/class/event_sources/cpu_hw_cache_eventsN
> > -> /sys/devices/system/cpu/cpuN/cpu_hw_events
>
> Hmm, good question.
>
> No all the cpus would have the same event sources. I'm not sure if we
> can make sysfs understand that though (added GregKH and Kay to CC).
>
> Possibly we'd have to place them at the cpu level, like:
>
> /sys/devices/system/cpu/cpu_*_events/
The problem with this is /sys/devices/system/ are the horrid sysdev
structures, which don't play nice (or at all) with the rest of the
driver/device model.
If we fix them up to finally work properly like real devices then we
could do this:
> and have links like:
>
> /sys/devices/system/cpu/cpuN/cpu_*_events ->
> /sys/devices/system/cpu/cpu_*_events/
>
> as well as
>
> /sys/class/event_sources/cpu_*_events ->
> /sys/devices/system/cpu/cpu_*_events/
Like you want to have done.
{sigh}
I guess I'll finally have to start working on this. I had some
conversations at the last Collab Summit with someone on how to properly
fix this all up, I'll go dig for that note and start in on it.
thanks,
greg k-h
next prev parent reply other threads:[~2010-05-11 15:51 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 9:27 [RFC][PATCH 3/9] perf: export registerred pmus via sysfs Lin Ming
2010-05-10 9:40 ` Peter Zijlstra
2010-05-10 10:11 ` Lin Ming
2010-05-10 10:18 ` Peter Zijlstra
2010-05-10 10:26 ` Lin Ming
2010-05-10 10:35 ` Paul Mundt
2010-05-10 10:58 ` Lin Ming
2010-05-10 11:04 ` Peter Zijlstra
2010-05-10 11:11 ` Lin Ming
2010-05-10 11:18 ` Lin Ming
2010-05-10 11:27 ` Peter Zijlstra
2010-05-10 11:36 ` Peter Zijlstra
2010-05-10 11:48 ` Ingo Molnar
2010-05-10 11:39 ` Russell King
2010-05-10 11:42 ` Peter Zijlstra
2010-05-10 20:25 ` Will Deacon
2010-05-11 6:34 ` Peter Zijlstra
2010-05-10 11:43 ` Ingo Molnar
2010-05-10 11:49 ` Peter Zijlstra
2010-05-10 11:53 ` Ingo Molnar
2010-05-10 23:13 ` Corey Ashford
2010-05-11 6:46 ` Peter Zijlstra
2010-05-11 7:21 ` Ingo Molnar
2010-05-11 8:20 ` Lin Ming
2010-05-11 8:50 ` Peter Zijlstra
2010-05-11 9:03 ` Lin Ming
2010-05-11 9:05 ` Lin Ming
2010-05-11 9:12 ` Peter Zijlstra
2010-05-11 9:18 ` Ingo Molnar
2010-05-11 9:24 ` Peter Zijlstra
2010-05-11 9:31 ` Ingo Molnar
2010-05-11 10:28 ` Lin Ming
2010-05-13 8:28 ` Lin Ming
2010-05-13 8:38 ` Ingo Molnar
2010-05-13 9:22 ` Lin Ming
2010-05-11 9:40 ` Lin Ming
2010-05-11 9:48 ` Peter Zijlstra
2010-05-11 9:53 ` Lin Ming
2010-05-11 15:17 ` Greg KH [this message]
2010-05-12 5:51 ` Paul Mundt
2010-05-12 8:37 ` Peter Zijlstra
2010-05-14 7:04 ` Paul Mundt
2010-05-11 10:09 ` stephane eranian
2010-05-11 14:15 ` Borislav Petkov
2010-05-11 14:25 ` Peter Zijlstra
2010-05-11 15:37 ` Borislav Petkov
2010-05-11 15:46 ` Peter Zijlstra
2010-05-10 23:54 ` Corey Ashford
2010-05-11 6:50 ` Peter Zijlstra
2010-05-11 2:43 ` Lin Ming
2010-05-11 6:35 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100511151747.GA16561@kroah.com \
--to=greg@kroah.com \
--cc=Gary.Mohr@bull.com \
--cc=acme@redhat.com \
--cc=arjan@linux.intel.com \
--cc=carll@us.ibm.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=fweisbec@gmail.com \
--cc=kay.sievers@vrfy.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=mpjohn@us.ibm.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=will.deacon@arm.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox