public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Stephane Eranian" <eranian@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	mingo@elte.hu, "Paul Mackerras" <paulus@samba.org>,
	"David S. Miller" <davem@davemloft.net>,
	perfmon2-devel@lists.sf.net
Subject: Re: [RFC] perf: perf record sets inherit by default
Date: Tue, 11 May 2010 12:50:39 -0300	[thread overview]
Message-ID: <20100511155039.GF19192@ghostprotocols.net> (raw)
In-Reply-To: <1273590800.1810.19.camel@laptop>

Em Tue, May 11, 2010 at 05:13:20PM +0200, Peter Zijlstra escreveu:
> On Tue, 2010-05-11 at 12:00 -0300, Arnaldo Carvalho de Melo wrote:
> > Humm, since for -C and -a using -i doesn't make sense, I guess it should
> > be off by default and only be auto-activated if we don't specify any
> > option, i.e. when using it like:

> > perf record ./hackbench
 
> -ENOPARSE
 
> -a/-C usage creates per-cpu counters and will thus ignore any and all
> perf_event_attr::inherit state.

What I tried to say was that if one does:

perf record -t 1234

then inherit would be off, or if:

perf record -p 5678

it would also be off.

but when just pass some program to run, like in:

perf record make -j allmodconfig

we would then assume that the user is interested in everything that the
program perf is starting does, i.e. the user is interested in the whole
workload started from perf, thus we would auto-enable -i.

> Your above suggestion would still have inherit enabled by default, and
> would thus not change anything.

Nope, see above.
 
- Arnaldo

  parent reply	other threads:[~2010-05-11 15:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-11 14:04 [RFC] perf: perf record sets inherit by default Stephane Eranian
2010-05-11 14:48 ` Peter Zijlstra
2010-05-17 14:25   ` Stephane Eranian
2010-05-17 16:48     ` Peter Zijlstra
2010-05-18 17:16       ` [tip:perf/core] perf: Optimize buffer placement by allocating buffers NUMA aware tip-bot for Peter Zijlstra
2010-05-11 15:00 ` [RFC] perf: perf record sets inherit by default Arnaldo Carvalho de Melo
2010-05-11 15:13   ` Peter Zijlstra
2010-05-11 15:17     ` Stephane Eranian
2010-05-11 15:50     ` Arnaldo Carvalho de Melo [this message]
2010-05-11 15:52       ` Peter Zijlstra
2010-05-11 15:55         ` Stephane Eranian
2010-05-11 15:59           ` Arnaldo Carvalho de Melo
2010-05-11 15:56         ` Arnaldo Carvalho de Melo
2010-05-11 16:01           ` Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100511155039.GF19192@ghostprotocols.net \
    --to=acme@infradead.org \
    --cc=davem@davemloft.net \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=perfmon2-devel@lists.sf.net \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox