Re: [git pull request] ACPI patches for 2.6.34-rc6

Linus Torvalds
2010-05-07T02:36:06Z

On Thu, 6 May 2010, Len Brown wrote:
>
> The big DMI list in sleep.c a temporary brute force and low-risk workaround.
> We will endeavor to delete it entirely in 2.6.35 with a clean fix
> that was deemed too risky for this late in the .34 release cycle.

Btw, why don't we just force the SCI_EN by hand?

We did that for the Apple Mac Mini bug too. It was always the right thing
to do.

There is _no_ reason not to force it. If the BIOS set it, it's a no-op. If
the BIOS didn't set it, it's a bug that _must_ be fixed.

I really don't see the reason for that DMI list. What could _possibly_ go
wrong for just setting the damn bit that we _know_ has to be set?

How could setting SCI_EN _ever_ be a bug? Seriously? Why are we doing this
conditionally, especially considering that even the commit message here
explicitly states that Windows does it unconditionally?

And no, I'm not interested in "that toilet paper spec says you can't touch
it". I care about _reality_.

Linus