Re: [git pull request] ACPI patches for 2.6.34-rc6

Matthew Garrett
2010-05-07T06:12:14Z

On Thu, May 06, 2010 at 07:34:10PM -0700, Linus Torvalds wrote:
>
>
> On Thu, 6 May 2010, Len Brown wrote:
> >
> > The big DMI list in sleep.c a temporary brute force and low-risk workaround.
> > We will endeavor to delete it entirely in 2.6.35 with a clean fix
> > that was deemed too risky for this late in the .34 release cycle.
>
> Btw, why don't we just force the SCI_EN by hand?

The spec says we can't. I've posted a patch to do so if it's still not
set after we've tried doing it the right way, but I'm not keen on
pushing it into a release at this point.

> There is _no_ reason not to force it. If the BIOS set it, it's a no-op. If
> the BIOS didn't set it, it's a bug that _must_ be fixed.

Kind of. The "correct" way to do it is to write to an ioport, and doing
that usually triggers an SMI. So writing the bit by hand without
ensuring that we do that is a difference in behaviour, while we've
simultaneously seen some evidence triggering that SMI may break some
machines - it's conceivable that Windows does it on boot and writes it
by hand on resume and so every machine in the real world would be fine
with us doing it by hand, but we haven't tested that yet and it doesn't
seem like a great risk to take at this point in the development cycle.
But yes, that DMI list will go in .35. We'll figure out who breaks and
why at that point.

> How could setting SCI_EN _ever_ be a bug? Seriously? Why are we doing this
> conditionally, especially considering that even the commit message here
> explicitly states that Windows does it unconditionally?

If the southbridge comes up with GPEs enabled in a way that expects one
thing and we write the bit differently without SMM being involved in the
process then there's potential misery. I suspect that any such misery is
entirely due to BIOS vendors being insane, but unfortunately scientific
testing has demonstrated that BIOS vendors are insane with a P of <
0.001 and an N of MAX_INT.

--
Matthew Garrett | mjg59@srcf.ucam.org