Re: [git pull request] ACPI patches for 2.6.34-rc6

Rafael J. Wysocki
2010-05-08T00:02:39Z

On Saturday 08 May 2010, Linus Torvalds wrote:
>
> On Sat, 8 May 2010, Rafael J. Wysocki wrote:
...
>
> Let me explain what I think we should do with actual code:
>
> acpi_enable();
> if (test_if_that_f_cking_bit_still_isnt_set)
> set_it_by_hand();
>
> wouldn't that work on your box?

Yes, it would.

> The acpi_enable() seems to work for you, so it wouldn't actually ever set it
> by hand.
>
> But the problem is that on a number of boxes, acpi_enable() apparently
> doesn't do what it should do. Because the stupid BIOS "knows" it is
> already in ACPI mode, but it forgot to actually set the bit!

To calrify, I think the approach in the Matthew's patch is correct, but since I have
some bad experience with that particular thing, I prefer to make that change in
2.6.35 and then move on to drop the flag entirely.

Rafael