Re: [git pull request] ACPI patches for 2.6.34-rc6

Linus Torvalds
2010-05-07T21:23:12Z

On Fri, 7 May 2010, Matthew Garrett wrote:

> On Fri, May 07, 2010 at 02:06:53PM -0700, Linus Torvalds wrote:
> > On Fri, 7 May 2010, Matthew Garrett wrote:
> > >
> > > The spec says we can't. I've posted a patch to do so if it's still not
> > > set after we've tried doing it the right way, but I'm not keen on
> > > pushing it into a release at this point.
> >
> > I'm ok with the "release at this point".
>
> http://git.kernel.org/?p=linux/kernel/git/lenb/linux-acpi-2.6.git;a=commit;h=3b12303e6bda6e05579d899fb71cb3e9d3bc26ba

Well, is there any reason to have 'set_sci_en_on_resume' at all then?

I mean, the only reason for that config thing in the first place is that
we didn't do this from the beginning. No?

And I'd hate to then carry the DMI table along forever just to set a
variable that isn't worth setting any more..

IOW, I don't disagree with the patch. I just don't think it went far
enough.

Linus