Re: [git pull request] ACPI patches for 2.6.34-rc6

Matthew Garrett
2010-05-07T21:36:11Z

On Fri, May 07, 2010 at 02:21:08PM -0700, Linus Torvalds wrote:
> On Fri, 7 May 2010, Matthew Garrett wrote:
>
> > On Fri, May 07, 2010 at 02:06:53PM -0700, Linus Torvalds wrote:
> > > On Fri, 7 May 2010, Matthew Garrett wrote:
> > > >
> > > > The spec says we can't. I've posted a patch to do so if it's still not
> > > > set after we've tried doing it the right way, but I'm not keen on
> > > > pushing it into a release at this point.
> > >
> > > I'm ok with the "release at this point".
> >
> > http://git.kernel.org/?p=linux/kernel/git/lenb/linux-acpi-2.6.git;a=commit;h=3b12303e6bda6e05579d899fb71cb3e9d3bc26ba
>
> Well, is there any reason to have 'set_sci_en_on_resume' at all then?

I'd hope not, but it depends on what Windows does on resume. If it
doesn't do the SMM call and just does the register write instead, then
it may be that some machines are on that list because the SMM call
breaks them rather than because they need the register to be set by
hand. I'm planning on instrumenting it to check, but haven't had time to
do so yet.

--
Matthew Garrett | mjg59@srcf.ucam.org