From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Daniel Mack <daniel@caiaq.de>
Cc: linux-kernel@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
Alexey Starikovskiy <astarikovskiy@suse.de>,
Len Brown <len.brown@intel.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Matt Reimer <mreimer@vpop.net>,
Evgeniy Polyakov <zbr@ioremap.net>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH 1/3] pda_power: add support for writeable properties
Date: Tue, 11 May 2010 22:23:47 +0400 [thread overview]
Message-ID: <20100511182347.GA31831@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20100511175812.GH30801@buzzloop.caiaq.de>
On Tue, May 11, 2010 at 07:58:12PM +0200, Daniel Mack wrote:
[...]
> Hmm, no. The code defaults to (S_IRUSR | S_IRGRP | S_IROTH) which is
> 0444, just like it was before. So there shouldn't be any regression. The
> mode is only changed if the psy defines a property_is_writeable()
> callback which returns 1. Or do I miss your point?
Yes, power_supply_attrs is a global array, and you shouldn't change
it between power_supply_register() calls.
If you don't see why it's a bad idea in general, think about it
other way, a race:
...someone registers psy0 with attr X marked as read-only...
...code flow stops before device_create_file(psy0, global->mode)..
[preempt]
...someone registers psy1 with attr X marked as writable...
...you set up global->mode to 0644...
[preempt again]
...we end up calling device_create_file(psy0, 0644)...
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2010-05-11 18:23 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 16:38 [PATCH 1/3] pda_power: add support for writeable properties Daniel Mack
2010-05-11 16:38 ` [PATCH 2/3] power/ds2760_battery: make charge_now and charge_full writeable Daniel Mack
2010-05-11 16:44 ` Daniel Mack
2010-05-11 17:20 ` Anton Vorontsov
2010-05-11 17:28 ` Daniel Mack
2010-05-11 18:05 ` Anton Vorontsov
2010-05-18 18:24 ` Daniel Mack
2010-05-11 16:38 ` [PATCH 3/3] power/ds2760_battery: use factor of 20 for rated_capacity Daniel Mack
2010-05-11 17:19 ` Anton Vorontsov
2010-05-11 17:25 ` Daniel Mack
2010-05-11 17:47 ` Anton Vorontsov
2010-05-11 17:47 ` [PATCH 1/3] pda_power: add support for writeable properties Anton Vorontsov
2010-05-11 17:58 ` Daniel Mack
2010-05-11 18:23 ` Anton Vorontsov [this message]
2010-05-11 22:28 ` Daniel Mack
2010-05-12 18:15 ` [PATCH] Introduce {sysfs,device}_create_file_mode Anton Vorontsov
2010-05-12 18:18 ` Daniel Mack
2010-05-12 18:38 ` Greg KH
2010-05-12 19:08 ` Anton Vorontsov
2010-05-12 19:12 ` Kay Sievers
2010-05-12 19:19 ` Greg KH
2010-05-12 19:39 ` Anton Vorontsov
2010-05-12 19:30 ` Anton Vorontsov
2010-05-13 9:33 ` Daniel Mack
2010-05-17 19:40 ` [PATCH] power_supply: Use attribute groups Anton Vorontsov
2010-05-18 17:35 ` Daniel Mack
2010-05-18 19:49 ` [PATCH 1/3] " Daniel Mack
2010-05-18 19:49 ` [PATCH 2/3] pda_power: add support for writeable properties Daniel Mack
2010-05-18 19:56 ` Greg KH
2010-05-18 20:30 ` [PATCH] power/ds2760_battery: document ABI change Daniel Mack
2010-05-19 8:34 ` Anton Vorontsov
2010-05-18 19:49 ` [PATCH 3/3] power/ds2760_battery: make charge_now and charge_full writeable Daniel Mack
2010-05-11 18:32 ` [PATCH 1/3] pda_power: add support for writeable properties Anton Vorontsov
-- strict thread matches above, loose matches on Subject: below --
2010-05-07 17:52 Daniel Mack
2010-05-07 17:54 ` Daniel Mack
2010-05-10 9:48 ` Mark Brown
2010-05-10 13:29 ` Daniel Mack
2010-03-23 9:06 Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100511182347.GA31831@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=astarikovskiy@suse.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=daniel@caiaq.de \
--cc=dwmw2@infradead.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mreimer@vpop.net \
--cc=tj@kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).