From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Len Brown <lenb@kernel.org>
Cc: Konrad Rzeszutek Wilk <konrad@kernel.org>,
linux-kernel@vger.kernel.org, gpxe-devel@etherboot.org,
Peter Jones <pjones@redhat.com>
Subject: Re: [LKML] Re: [PATCH 1/2] ibft: Update iBFT handling for v1.03 of the spec.
Date: Wed, 12 May 2010 09:58:43 -0400 [thread overview]
Message-ID: <20100512135843.GA5686@phenom.dumpdata.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1005120125170.5297@localhost.localdomain>
On Wed, May 12, 2010 at 01:26:59AM -0400, Len Brown wrote:
>
> > #define IBFT_SIGN "iBFT"
> ...
> > +#ifdef CONFIG_ACPI
> > + /*
> > + * One spec says "IBFT", the other says "iBFT". We have to check
> > + * for both.
> > + */
>
> Really?
> Which one do you see in the field?
The one machine I do remember seeing this in the ACPI tables was the IBM
HS20, but I can't remember which one it was. Mike, Peter - any
recollection? Don't know about about Intel ones.
For cases where there was no ACPI, the 'iBFT' was definitly the string I saw.
> any reason to #define "iBFT" above and not use it below?
>
> > + if (!ibft_addr)
> > + acpi_table_parse(ACPI_SIG_IBFT, acpi_find_ibft);
> > + if (!ibft_addr)
> > + acpi_table_parse("iBFT", acpi_find_ibft);
Could definitly use the IBFT_SIGN here.
Thanks for taking a look!
next prev parent reply other threads:[~2010-05-12 13:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 14:21 [PATCH] Update iBFT to 1.03 Konrad Rzeszutek Wilk
2010-04-09 14:21 ` [PATCH 1/2] ibft: Update iBFT handling for v1.03 of the spec Konrad Rzeszutek Wilk
2010-04-21 21:26 ` Andrew Morton
2010-05-11 17:58 ` Konrad Rzeszutek Wilk
2010-05-12 5:26 ` Len Brown
2010-05-12 13:58 ` Konrad Rzeszutek Wilk [this message]
2010-05-12 14:09 ` Peter Jones
2010-05-12 14:12 ` [PATCH] Use IBFT_SIGN instead of open-coding the search string Peter Jones
2010-05-12 14:25 ` Peter Jones
2010-05-12 14:35 ` [PATCH] ibft: " Konrad Rzeszutek Wilk
2010-05-12 19:33 ` Andrew Morton
2010-05-12 23:53 ` H. Peter Anvin
2010-05-27 17:59 ` Konrad Rzeszutek Wilk
2010-04-09 14:21 ` [PATCH 2/2] ibft: For UEFI machines actually do scan ACPI for iBFT Konrad Rzeszutek Wilk
2010-04-21 21:29 ` Andrew Morton
2010-04-21 21:37 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100512135843.GA5686@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=gpxe-devel@etherboot.org \
--cc=konrad@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).