From: Frederic Weisbecker <fweisbec@gmail.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, paulus@samba.org, davem@davemloft.net,
acme@infradead.org, perfmon2-devel@lists.sf.net,
eranian@gmail.com
Subject: Re: [PATCH] perf: change event inheritance logic in stat and record
Date: Wed, 12 May 2010 17:24:52 +0200 [thread overview]
Message-ID: <20100512152447.GF5405@nowhere> (raw)
In-Reply-To: <4bea9d2f.d60ce30a.0b5b.08e1@mx.google.com>
On Wed, May 12, 2010 at 10:40:01AM +0200, Stephane Eranian wrote:
> By default, event inheritance across fork and pthread_create was
> on but the -i option of stat and record, which enabled inheritance,
> led to believe it was off by default.
>
> This patch fixes this logic by inverting the meaning of the -i option.
> By default inheritance is on whether you attach to a process (-p), a
> thread (-t) or start a process. If you pass -i, then you turn off
> inheritance. Turning off inheritance if you don't need it, helps
> limit perf resource usage as well.
>
> The patch also fixes perf stat -t xxxx and perf record -t xxxx
> which did not start the counters.
>
> Signed-off-by: Stephane Eranian <eranian@google.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
prev parent reply other threads:[~2010-05-12 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 8:40 [PATCH] perf: change event inheritance logic in stat and record Stephane Eranian
2010-05-12 15:24 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100512152447.GF5405@nowhere \
--to=fweisbec@gmail.com \
--cc=acme@infradead.org \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=perfmon2-devel@lists.sf.net \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).