From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Pekka Paalanen <pq@iki.fi>
Subject: [PATCH 3/4] tracing: Allow mmio tracer to display trace_printk() and other events
Date: Wed, 12 May 2010 21:21:13 -0400 [thread overview]
Message-ID: <20100513012302.352845720@goodmis.org> (raw)
In-Reply-To: 20100513012110.558313399@goodmis.org
[-- Attachment #1: 0003-tracing-Allow-mmio-tracer-to-display-trace_printk-an.patch --]
[-- Type: text/plain, Size: 1267 bytes --]
From: Steven Rostedt <srostedt@redhat.com>
The mmio tracer has its own function to handle reading of events.
But if it encounters an event that it does not understand it ignores
it instead of telling the calling function that it is not processing
it.
If someone adds trace_printk() or enables events along with the mmio
tracer, then these events will not be displayed in the trace output.
Simple solution is to just have the mmio print return UNHANDLED to
let the caller know that it did not processes the event and the
caller can process the event further.
Reported-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Pekka Paalanen <pq@iki.fi>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/trace_mmiotrace.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace_mmiotrace.c b/kernel/trace/trace_mmiotrace.c
index 017fa37..592c00f 100644
--- a/kernel/trace/trace_mmiotrace.c
+++ b/kernel/trace/trace_mmiotrace.c
@@ -282,7 +282,8 @@ static enum print_line_t mmio_print_line(struct trace_iterator *iter)
case TRACE_PRINT:
return mmio_print_mark(iter);
default:
- return TRACE_TYPE_HANDLED; /* ignore unknown entries */
+ /* Not our event */
+ return TRACE_TYPE_UNHANDLED;
}
}
--
1.7.0
next prev parent reply other threads:[~2010-05-13 1:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 1:21 [PATCH 0/4] [GIT PULL] tracing: updates Steven Rostedt
2010-05-13 1:21 ` [PATCH 1/4] tracing: Fix function declarations if !CONFIG_STACKTRACE Steven Rostedt
2010-05-13 1:21 ` [PATCH 2/4] tracing/sched: Fix task states in sched switch event Steven Rostedt
2010-05-13 6:15 ` Ingo Molnar
2010-05-13 1:21 ` Steven Rostedt [this message]
2010-05-13 8:54 ` [PATCH 3/4] tracing: Allow mmio tracer to display trace_printk() and other events Pekka Paalanen
2010-05-13 12:15 ` Steven Rostedt
2010-05-13 12:29 ` Pekka Paalanen
2010-05-13 15:11 ` Steven Rostedt
2010-05-13 19:42 ` Steven Rostedt
2010-05-15 7:46 ` Pekka Paalanen
2010-05-16 1:29 ` Steven Rostedt
2010-05-13 1:21 ` [PATCH 4/4] tracing: Update branch trace to new event API Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100513012302.352845720@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pq@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).