From: Dan Carpenter <error27@gmail.com>
To: James Bottomley <James.Bottomley@suse.de>
Cc: Tejun Heo <tj@kernel.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] libsas: dereferencing variable before check
Date: Thu, 13 May 2010 20:42:32 +0200 [thread overview]
Message-ID: <20100513184232.GC5695@bicker> (raw)
In-Reply-To: <1273761114.4353.122.camel@mulgrave.site>
On Thu, May 13, 2010 at 09:31:54AM -0500, James Bottomley wrote:
> On Thu, 2010-05-13 at 01:08 +0200, Tejun Heo wrote:
> >
> > "Dan Carpenter" <error27@gmail.com> wrote:
> >
> > >The "qc->scsicmd" could be null so I moved the dereference inside the
> > >check. This was introduced by 70b25f890: "[SCSI] fix locking around
> > >blk_abort_request()"
> > >
> > >Signed-off-by: Dan Carpenter <error27@gmail.com>
> >
> > Ooh.. right.
> >
> > Asked-by: Tejun Heo <tj@kernel.org>
>
> Well, oops, yes. Two patches to fix one bug is a bit overboard, I
> think, plus some code rearrangement to fix the locality of the problem
> and ensure it doesn't happen again might be useful. What about this.
>
Looks good.
Acked-by: Dan Carpenter <error27@gmail.com>
regards,
dan carpenter
prev parent reply other threads:[~2010-05-13 18:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 22:56 [patch] libsas: dereferencing variable before check Dan Carpenter
2010-05-12 23:08 ` Tejun Heo
2010-05-13 14:31 ` James Bottomley
2010-05-13 14:37 ` Tejun Heo
2010-05-13 18:42 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100513184232.GC5695@bicker \
--to=error27@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).