From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759010Ab0EMVs2 (ORCPT ); Thu, 13 May 2010 17:48:28 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:51265 "EHLO e6.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932278Ab0EMVsY (ORCPT ); Thu, 13 May 2010 17:48:24 -0400 Date: Thu, 13 May 2010 14:48:18 -0700 From: "Paul E. McKenney" To: Matt Helsley Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org, dvhltc@us.ibm.com, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, eric.dumazet@gmail.com, Arnd Bergmann , Christopher Li Subject: Re: [PATCH RFC tip/core/rcu 02/23] rcu: add __rcu API for later sparse checking Message-ID: <20100513214818.GL2879@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20100512213317.GA15085@linux.vnet.ibm.com> <1273700022-16523-2-git-send-email-paulmck@linux.vnet.ibm.com> <20100513205307.GS31830@count0.beaverton.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100513205307.GS31830@count0.beaverton.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 13, 2010 at 01:53:07PM -0700, Matt Helsley wrote: > On Wed, May 12, 2010 at 02:33:21PM -0700, Paul E. McKenney wrote: > > This commit defines an __rcu API, but provides only vacuous definitions > > for it. This breaks dependencies among most of the subsequent patches, > > allowing them to reach mainline asynchronously via whatever trees are > > appropriate. > > Seems like a good plan to me. > > I know it's not the right time to push it but I am curious to see what, > approximately, you expect a non-vacuous __rcu definition to look like. > (i.e. when it's being run through sparse) Patch 6 of this series defines the sparse magic and the rcu_dereference() checks that do this. But yes, there are dependencies among these patches. Thanx, Paul > Cheers, > -Matt Helsley > > > > > Signed-off-by: Arnd Bergmann > > Signed-off-by: Paul E. McKenney > > Cc: Christopher Li > > Cc: Josh Triplett > > --- > > include/linux/compiler.h | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/include/linux/compiler.h b/include/linux/compiler.h > > index a5a472b..c1a62c5 100644 > > --- a/include/linux/compiler.h > > +++ b/include/linux/compiler.h > > @@ -16,6 +16,7 @@ > > # define __release(x) __context__(x,-1) > > # define __cond_lock(x,c) ((c) ? ({ __acquire(x); 1; }) : 0) > > # define __percpu __attribute__((noderef, address_space(3))) > > +# define __rcu > > extern void __chk_user_ptr(const volatile void __user *); > > extern void __chk_io_ptr(const volatile void __iomem *); > > #else > > @@ -34,6 +35,7 @@ extern void __chk_io_ptr(const volatile void __iomem *); > > # define __release(x) (void)0 > > # define __cond_lock(x,c) (c) > > # define __percpu > > +# define __rcu > > #endif > > > > #ifdef __KERNEL__ > > -- > > 1.7.0.6 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/