From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756465Ab0ENBt6 (ORCPT ); Thu, 13 May 2010 21:49:58 -0400 Received: from mga03.intel.com ([143.182.124.21]:60539 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755313Ab0ENBt4 (ORCPT ); Thu, 13 May 2010 21:49:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.53,225,1272870000"; d="scan'208";a="276963671" Date: Fri, 14 May 2010 09:45:35 +0800 From: Shaohui Zheng To: Greg KH Cc: akpm@linux-foundation.org, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Hidetoshi Seto , David Rientjes , Alex Chiang , linux-kernel@vger.kernel.org, ak@linux.intel.com, fengguang.wu@intel.com, haicheng.li@linux.intel.com, shaohui.zheng@linux.intel.com Subject: Re: [RFC, 3/7] NUMA hotplug emulator Message-ID: <20100514014535.GA4381@shaohui> Mail-Followup-To: Greg KH , akpm@linux-foundation.org, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Hidetoshi Seto , David Rientjes , Alex Chiang , linux-kernel@vger.kernel.org, ak@linux.intel.com, fengguang.wu@intel.com, haicheng.li@linux.intel.com, shaohui.zheng@linux.intel.com References: <20100513114835.GD2169@shaohui> <20100513165511.GB25212@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100513165511.GB25212@suse.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 13, 2010 at 09:55:11AM -0700, Greg KH wrote: > On Thu, May 13, 2010 at 07:48:35PM +0800, Shaohui Zheng wrote: > > Userland interface to hotplug-add fake offlined nodes. > > Why include 2 copies of the patch in one email? I always try to attach the patch as attachment, it is the same with the mail content, I guess it should take convenience when you need to save the patch to local, it might be a bad habbit, I will be careful when I send patch next time. thanks for the reminding. > > > Add a sysfs entry "probe" under /sys/devices/system/node/: > > > > - to show all fake offlined nodes: > > $ cat /sys/devices/system/node/probe > > > > - to hotadd a fake offlined node, e.g. nodeid is N: > > $ echo N > /sys/devices/system/node/probe > > As you are trying to add a new sysfs file, please create the matching > Documentation/ABI/ file as well. Agree, We will document it in. > > Also note that sysfs files are "one value per file", which I don't think > this file follows, right? Agree, the cpu/probe interface should write only, and we should create another file to indicate the hidden nodes, such as cpu/hidden. We will follow this rule when we send the formal patch. Thanks greg's comments so much, have a nice day. > > thanks, > > greg k-h -- Thanks & Regards, Shaohui