From: Huaxu Wan <huaxu.wan@linux.intel.com>
To: linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Cc: huaxu.wan@intel.com, Valdis.Kletnieks@vt.edu,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Subject: [PATCH 1/2 V3 minor change] hwmon: (coretemp) Detect the thermal sensors by CPUID
Date: Fri, 14 May 2010 14:58:08 +0800 [thread overview]
Message-ID: <20100514065808.GA11598@owl> (raw)
In-Reply-To: <20100514032000.GB17786@khazad-dum.debian.net>
The thermal sensors of Intel(R) CPUs can be detected by CPUID instruction,
indicated by CPUID.06H.EAX[0].
Signed-off-by: Huaxu Wan <huaxu.wan@linux.intel.com>
Signed-off-by: Carsten Emde <C.Emde@osadl.org>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
---
drivers/hwmon/coretemp.c | 34 +++++++++++++---------------------
1 files changed, 13 insertions(+), 21 deletions(-)
diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index e9b7fbc..885da2b 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -451,28 +451,20 @@ static int __init coretemp_init(void)
for_each_online_cpu(i) {
struct cpuinfo_x86 *c = &cpu_data(i);
+ /*
+ * CPUID.06H.EAX[0] indicates whether the CPU has thermal
+ * sensors. We check this bit only, all the early CPUs
+ * without thermal sensors will be filtered out.
+ */
+ if (c->cpuid_level >= 6 && (cpuid_eax(0x06) & 0x01)) {
+ err = coretemp_device_add(i);
+ if (err)
+ goto exit_devices_unreg;
- /* check if family 6, models 0xe (Pentium M DC),
- 0xf (Core 2 DC 65nm), 0x16 (Core 2 SC 65nm),
- 0x17 (Penryn 45nm), 0x1a (Nehalem), 0x1c (Atom),
- 0x1e (Lynnfield) */
- if ((c->cpuid_level < 0) || (c->x86 != 0x6) ||
- !((c->x86_model == 0xe) || (c->x86_model == 0xf) ||
- (c->x86_model == 0x16) || (c->x86_model == 0x17) ||
- (c->x86_model == 0x1a) || (c->x86_model == 0x1c) ||
- (c->x86_model == 0x1e))) {
-
- /* supported CPU not found, but report the unknown
- family 6 CPU */
- if ((c->x86 == 0x6) && (c->x86_model > 0xf))
- printk(KERN_WARNING DRVNAME ": Unknown CPU "
- "model 0x%x\n", c->x86_model);
- continue;
- }
-
- err = coretemp_device_add(i);
- if (err)
- goto exit_devices_unreg;
+ } else {
+ printk(KERN_INFO DRVNAME ": CPU (model=0x%x)"
+ " has no thermal sensor.\n", c->x86_model);
+ }
}
if (list_empty(&pdev_list)) {
err = -ENODEV;
--
1.6.3.3.363.g725cf7
next prev parent reply other threads:[~2010-05-14 6:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 9:54 [PATCH 1/2] hwmon: (coretemp) Detect the thermal sensors by CPUID Huaxu Wan
2010-05-07 12:43 ` Jean Delvare
2010-05-07 13:21 ` [lm-sensors] " Carsten Emde
2010-05-10 2:35 ` Huaxu Wan
2010-05-10 3:35 ` [PATCH 1/2 V2] " Huaxu Wan
2010-05-10 12:45 ` Valdis.Kletnieks
2010-05-11 3:41 ` Huaxu Wan
2010-05-11 8:01 ` [PATCH 1/2 V3] " Huaxu Wan
2010-05-11 21:45 ` Valdis.Kletnieks
2010-05-14 3:20 ` [lm-sensors] " Henrique de Moraes Holschuh
2010-05-14 6:58 ` Huaxu Wan [this message]
2010-05-17 9:41 ` [PATCH 0/2] hwmon: Update coretemp to current Intel processors Carsten Emde
2010-05-17 9:41 ` [PATCH 1/2] Detect the thermal sensors by CPUID Carsten Emde
2010-05-17 9:41 ` [PATCH 2/2] Get TjMax value from MSR Carsten Emde
[not found] ` <AANLkTinQlH7LhCAz00WaHqbbslcSqipzVx4tDoQKSqIL@mail.gmail.com>
2010-05-18 7:01 ` [lm-sensors] [PATCH 0/2] hwmon: Update coretemp to current Intel processors Carsten Emde
2010-05-18 12:03 ` Dmitry Gromov
2010-05-19 1:27 ` Huaxu Wan
[not found] ` <625BA99ED14B2D499DC4E29D8138F150181F574C31@shsmsx502.ccr.corp.intel.com>
[not found] ` <AANLkTimQnaUvXs75rpTOcW7CODXWgUfzekY9FCDa5S8P@mail.gmail.com>
2010-05-18 7:13 ` Carsten Emde
2010-05-19 0:50 ` Huaxu Wan
2010-05-19 3:12 ` Dmitry Gromov
-- strict thread matches above, loose matches on Subject: below --
2010-05-07 9:59 [PATCH 2/2] hwmon: (coretemp) Get TjMax value from MSR Huaxu Wan
2010-05-07 13:29 ` [lm-sensors] " Carsten Emde
2010-05-10 3:09 ` Huaxu Wan
2010-05-10 3:50 ` [PATCH 2/2 V2] " Huaxu Wan
2010-05-29 5:39 ` [PATCH 2/2] " Maxim Levitsky
2010-05-30 14:43 ` Maxim Levitsky
2010-05-31 1:39 ` Huaxu Wan
2010-06-02 16:34 ` Maxim Levitsky
2010-06-02 20:10 ` Maxim Levitsky
2010-06-12 13:03 ` Maxim Levitsky
2010-06-13 2:27 ` Wan, Huaxu
2010-07-26 8:16 ` Maxim Levitsky
2010-08-30 1:42 ` Huaxu Wan
2010-08-31 21:01 ` Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100514065808.GA11598@owl \
--to=huaxu.wan@linux.intel.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=hmh@hmh.eng.br \
--cc=huaxu.wan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox