From: Ingo Molnar <mingo@elte.hu>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>,
Jaswinder Singh Rajput <jaswinderlinux@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: Performance Events hangs with Intel P4 system
Date: Fri, 14 May 2010 13:56:55 +0200 [thread overview]
Message-ID: <20100514115655.GA18069@elte.hu> (raw)
In-Reply-To: <1273834571.3530.82.camel@minggr.sh.intel.com>
* Lin Ming <ming.m.lin@intel.com> wrote:
> p4_event_bind::cntr is "unsigned char".
> But p4_next_cntr has return type of "int".
> So the explicit conversion is needed to get the correct result.
> @@ -780,7 +780,7 @@ static int p4_pmu_schedule_events(struct cpu_hw_events *cpuc, int n, int *assign
> if (unlikely(escr_idx == -1))
> goto done;
>
> - if (hwc->idx != -1 && !p4_should_swap_ts(hwc->config, cpu)) {
> + if (hwc->idx != (unsigned char)-1 && !p4_should_swap_ts(hwc->config, cpu)) {
That cast is _extremely_ ugly. Please fix the signedness of the types instead.
Ingo
next prev parent reply other threads:[~2010-05-14 11:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 22:17 Performance Events hangs with Intel P4 system Jaswinder Singh Rajput
2010-05-14 3:19 ` Cyrill Gorcunov
2010-05-14 4:25 ` Jaswinder Singh Rajput
2010-05-14 4:29 ` Cyrill Gorcunov
2010-05-14 6:23 ` Cyrill Gorcunov
2010-05-14 7:52 ` Jaswinder Singh Rajput
2010-05-14 8:41 ` Cyrill Gorcunov
2010-05-14 10:04 ` Cyrill Gorcunov
2010-05-14 10:46 ` Cyrill Gorcunov
2010-05-14 10:56 ` Lin Ming
2010-05-14 11:56 ` Ingo Molnar [this message]
2010-05-14 12:07 ` Cyrill Gorcunov
2010-05-14 13:52 ` Cyrill Gorcunov
2010-05-14 14:52 ` Cyrill Gorcunov
2010-05-14 16:22 ` Jaswinder Singh Rajput
2010-05-14 16:28 ` Cyrill Gorcunov
2010-05-14 16:36 ` Jaswinder Singh Rajput
2010-05-14 16:40 ` Cyrill Gorcunov
2010-05-14 17:48 ` Jaswinder Singh Rajput
2010-05-14 18:01 ` Cyrill Gorcunov
2010-05-14 18:33 ` Jaswinder Singh Rajput
2010-05-14 17:30 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100514115655.GA18069@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=gorcunov@gmail.com \
--cc=jaswinderlinux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox