From: Oleg Nesterov <oleg@redhat.com>
To: Andrey Vagin <avagin@openvz.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, stable@kernel.org,
Pavel Emelyanov <xemul@openvz.org>,
Stanislaw Gruszka <sgruszka@redhat.com>
Subject: Re: [PATCH 1/2] posix_timer: separate timer_cleanup from timer_del
Date: Fri, 14 May 2010 18:01:35 +0200 [thread overview]
Message-ID: <20100514160135.GA3727@redhat.com> (raw)
In-Reply-To: <1273843731-12595-1-git-send-email-avagin@openvz.org>
(add Stanislaw)
On 05/14, Andrey Vagin wrote:
>
> Signed-off-by: Andrey Vagin <avagin@openvz.org>
You forgot to write the changelog ;)
> --- a/kernel/posix-cpu-timers.c
> +++ b/kernel/posix-cpu-timers.c
> @@ -455,14 +455,21 @@ int posix_cpu_timer_del(struct k_itimer *timer)
> spin_unlock(&p->sighand->siglock);
> }
> read_unlock(&tasklist_lock);
> -
> - if (!ret)
> - put_task_struct(p);
> }
>
> + if (!ret)
> + posix_cpu_timer_cleanup(timer);
> +
> return ret;
> }
Could you please explain this change?
Oleg.
next prev parent reply other threads:[~2010-05-14 16:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 13:28 [PATCH 1/2] posix_timer: separate timer_cleanup from timer_del Andrey Vagin
2010-05-14 13:28 ` [PATCH 2/2] posix_timer: clean up properly if anything fails after *_timer_create Andrey Vagin
2010-05-14 16:03 ` Oleg Nesterov
2010-05-14 17:18 ` Stanislaw Gruszka
2010-05-14 18:48 ` Oleg Nesterov
2010-05-15 14:17 ` Andrew Vagin
2010-05-14 16:01 ` Oleg Nesterov [this message]
2010-05-24 21:40 ` [stable] [PATCH 1/2] posix_timer: separate timer_cleanup from timer_del Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100514160135.GA3727@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox