From: Rusty Russell <rusty@rustcorp.com.au>
To: Milton Miller <miltonm@bga.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
anton@samba.org
Subject: Re: cpumask: fix compat getaffinity
Date: Fri, 14 May 2010 22:09:13 +0930 [thread overview]
Message-ID: <201005142209.14473.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1273653045_3386@mail4.comsite.net>
On Wed, 12 May 2010 06:00:45 pm Milton Miller wrote:
>
> At least for parsing, we need to allocate and parse NR_CPUS until
> all places like arch/powerpc/platforms/pseries/xics.c that compare a
> user-supplied mask to CPUMASK_ALL are eliminated.
Good point. Anton will want to fix those anyway for CONFIG_CPUMASK_OFFSTACK,
too, but that's the reason the parsing uses nr_cpumask_bits.
> > Would it make sense to use my initial patch for -stable, which reverts
> > the ABI back to before the change that caused the problem, but apply
> > the correct fix (changing the ABI throughout) for future releases?
>
> This would definitly be the conservative fix.
Instead of changing back to NR_CPUS which will break libnuma for
CPUMASK_OFFSTACK, how about changing it to nr_cpumask_bits and having an
explicit comment above it:
/* libnuma assumes we match scnprintf for /sys/.../node/node*/cpumap */
Thanks,
Rusty.
next prev parent reply other threads:[~2010-05-14 12:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 12:45 cpumask: fix compat getaffinity Arnd Bergmann
2010-05-08 8:30 ` Rusty Russell
2010-05-08 9:11 ` Arnd Bergmann
2010-05-10 23:43 ` Rusty Russell
2010-05-11 1:47 ` KOSAKI Motohiro
2010-05-11 3:13 ` [stable] " Greg KH
2010-05-11 5:51 ` Rusty Russell
2010-05-11 6:25 ` KOSAKI Motohiro
2010-05-11 6:20 ` KOSAKI Motohiro
2010-05-11 15:20 ` Greg KH
2010-05-11 18:13 ` Arnd Bergmann
2010-05-11 21:36 ` Greg KH
2010-05-12 8:30 ` Milton Miller
2010-05-14 12:39 ` Rusty Russell [this message]
2010-05-17 6:04 ` KOSAKI Motohiro
2010-05-17 18:58 ` Arnd Bergmann
2010-05-18 0:57 ` Rusty Russell
2010-12-14 16:59 ` Josh Hunt
2010-12-15 14:40 ` Arnd Bergmann
2010-06-22 23:30 ` Rusty Russell
2010-05-11 9:05 ` Arnd Bergmann
2010-05-12 0:52 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005142209.14473.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=anton@samba.org \
--cc=arnd@arndb.de \
--cc=greg@kroah.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miltonm@bga.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).