From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752877Ab0EPHLM (ORCPT ); Sun, 16 May 2010 03:11:12 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:58675 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752474Ab0EPHLK (ORCPT ); Sun, 16 May 2010 03:11:10 -0400 Date: Sun, 16 May 2010 00:11:16 -0700 (PDT) Message-Id: <20100516.001116.216765419.davem@davemloft.net> To: tj@kernel.org Cc: jeff@garzik.org, linux-ide@vger.kernel.org, jens.axboe@oracle.com, linux-scsi@vger.kernel.org, James.Bottomley@suse.de, linux-kernel@vger.kernel.org, ben@decadent.org.uk, bzolnier@gmail.com Subject: Re: [PATCH 1/8] buffer: make invalidate_bdev() drain all percpu LRU add caches From: David Miller In-Reply-To: <1273946974-29131-2-git-send-email-tj@kernel.org> References: <1273946974-29131-1-git-send-email-tj@kernel.org> <1273946974-29131-2-git-send-email-tj@kernel.org> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tejun Heo Date: Sat, 15 May 2010 20:09:27 +0200 > invalidate_bdev() should release all page cache pages which are clean > and not being used; however, if some pages are still in the percpu LRU > add caches on other cpus, those pages are considered in used and don't > get released. Fix it by calling lru_add_drain_all() before trying to > invalidate pages. > > This problem was discovered while testing block automatic native > capacity unlocking. Null pages which were read before automatic > unlocking didn't get released by invalidate_bdev() and ended up > interfering with partition scan after unlocking. > > Signed-off-by: Tejun Heo Acked-by: David S. Miller