* [PATCH] GPIO: rdc321x fix inverted gpio data out registers
@ 2010-05-16 10:02 Florian Fainelli
2010-05-16 22:25 ` Samuel Ortiz
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2010-05-16 10:02 UTC (permalink / raw)
To: linux-kernel, Samuel Ortiz, Andrew Morton
rdc_gpio_set_value_impl has the gpio data registers 1 and 2 inverted, fix this.
Signed-off-by: Bernhard Loos <bernhardloos@gmail.com>
Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
diff --git a/drivers/gpio/rdc321x-gpio.c b/drivers/gpio/rdc321x-gpio.c
index 22f31dc..2762698 100644
--- a/drivers/gpio/rdc321x-gpio.c
+++ b/drivers/gpio/rdc321x-gpio.c
@@ -73,7 +73,7 @@ static void rdc_gpio_set_value_impl(struct gpio_chip *chip,
gpch->data_reg[reg] &= ~(1 << (gpio & 0x1f));
pci_write_config_dword(gpch->sb_pdev,
- reg ? gpch->reg1_data_base : gpch->reg2_data_base,
+ reg ? gpch->reg2_data_base : gpch->reg1_data_base,
gpch->data_reg[reg]);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] GPIO: rdc321x fix inverted gpio data out registers
2010-05-16 10:02 [PATCH] GPIO: rdc321x fix inverted gpio data out registers Florian Fainelli
@ 2010-05-16 22:25 ` Samuel Ortiz
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Ortiz @ 2010-05-16 22:25 UTC (permalink / raw)
To: Florian Fainelli; +Cc: linux-kernel, Andrew Morton
Hi Florian,
On Sun, May 16, 2010 at 12:02:18PM +0200, Florian Fainelli wrote:
> rdc_gpio_set_value_impl has the gpio data registers 1 and 2 inverted, fix this.
>
Patch applied, thanks a lot.
Cheers,
Samuel.
> Signed-off-by: Bernhard Loos <bernhardloos@gmail.com>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> diff --git a/drivers/gpio/rdc321x-gpio.c b/drivers/gpio/rdc321x-gpio.c
> index 22f31dc..2762698 100644
> --- a/drivers/gpio/rdc321x-gpio.c
> +++ b/drivers/gpio/rdc321x-gpio.c
> @@ -73,7 +73,7 @@ static void rdc_gpio_set_value_impl(struct gpio_chip *chip,
> gpch->data_reg[reg] &= ~(1 << (gpio & 0x1f));
>
> pci_write_config_dword(gpch->sb_pdev,
> - reg ? gpch->reg1_data_base : gpch->reg2_data_base,
> + reg ? gpch->reg2_data_base : gpch->reg1_data_base,
> gpch->data_reg[reg]);
> }
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-16 22:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-16 10:02 [PATCH] GPIO: rdc321x fix inverted gpio data out registers Florian Fainelli
2010-05-16 22:25 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox