From: Samuel Ortiz <sameo@linux.intel.com>
To: Florian Fainelli <florian@openwrt.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] GPIO: rdc321x fix inverted gpio data out registers
Date: Mon, 17 May 2010 00:25:54 +0200 [thread overview]
Message-ID: <20100516222553.GD3236@sortiz.org> (raw)
In-Reply-To: <201005161202.21614.florian@openwrt.org>
Hi Florian,
On Sun, May 16, 2010 at 12:02:18PM +0200, Florian Fainelli wrote:
> rdc_gpio_set_value_impl has the gpio data registers 1 and 2 inverted, fix this.
>
Patch applied, thanks a lot.
Cheers,
Samuel.
> Signed-off-by: Bernhard Loos <bernhardloos@gmail.com>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> diff --git a/drivers/gpio/rdc321x-gpio.c b/drivers/gpio/rdc321x-gpio.c
> index 22f31dc..2762698 100644
> --- a/drivers/gpio/rdc321x-gpio.c
> +++ b/drivers/gpio/rdc321x-gpio.c
> @@ -73,7 +73,7 @@ static void rdc_gpio_set_value_impl(struct gpio_chip *chip,
> gpch->data_reg[reg] &= ~(1 << (gpio & 0x1f));
>
> pci_write_config_dword(gpch->sb_pdev,
> - reg ? gpch->reg1_data_base : gpch->reg2_data_base,
> + reg ? gpch->reg2_data_base : gpch->reg1_data_base,
> gpch->data_reg[reg]);
> }
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2010-05-16 22:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-16 10:02 [PATCH] GPIO: rdc321x fix inverted gpio data out registers Florian Fainelli
2010-05-16 22:25 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100516222553.GD3236@sortiz.org \
--to=sameo@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=florian@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox