From: Frederic Weisbecker <fweisbec@gmail.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, paulus@samba.org, davem@davemloft.net,
acme@infradead.org, perfmon2-devel@lists.sf.net,
eranian@gmail.com
Subject: Re: [PATCH] perf: fix bug mismatch with -c option definition
Date: Mon, 17 May 2010 13:29:40 +0200 [thread overview]
Message-ID: <20100517112937.GA5291@nowhere> (raw)
In-Reply-To: <4bf11ae9.e88cd80a.06b0.ffffa8e3@mx.google.com>
On Mon, May 17, 2010 at 12:04:01PM +0200, Stephane Eranian wrote:
> The -c option defines the user requested sampling period. It was implemented
> using an unsigned int variable but the type of the option was OPT_LONG. Thus,
> the option parser was overwriting memory belonging to other variables, namely
> the mmap_pages leading to a zero page sampling buffer. The bug was exposed
> only when compiling at -O0, probably because the compiler was padding
> variables at higher optimization levels.
>
> This patch fixes this problem by declaring user_interval as u64. This also
> avoids wrap-around issues for large period on 32-bit systems.
>
> Signed-off-by: Stephane Eranian <eranian@google.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Small detail: could you avoid the spaces in the beginning of
your changelog lines?
May be that's because you use git-show to dump your patches?
In which case I suggest you to use git-format-patch instead.
Thanks.
next prev parent reply other threads:[~2010-05-17 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 10:04 [PATCH] perf: fix bug mismatch with -c option definition Stephane Eranian
2010-05-17 11:29 ` Frederic Weisbecker [this message]
2010-05-17 14:19 ` Arnaldo Carvalho de Melo
2010-05-17 15:39 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100517112937.GA5291@nowhere \
--to=fweisbec@gmail.com \
--cc=acme@infradead.org \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=perfmon2-devel@lists.sf.net \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox