From: Jean Delvare <khali@linux-fr.org>
To: Steven King <sfking@fdwdc.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH v2] hwmon: driver for TI tmp102 temperature sensor
Date: Mon, 17 May 2010 14:20:19 +0200 [thread overview]
Message-ID: <20100517142019.36f392ad@hyperion.delvare> (raw)
In-Reply-To: <201005050831.56526.sfking@fdwdc.com>
Hi Steven,
On Wed, 5 May 2010 08:31:55 -0700, Steven King wrote:
> On Tuesday 04 May 2010 2:36:55 Jean Delvare wrote:
> > Steven,
> >
> > On Sat, 3 Apr 2010 09:23:40 +0200, Jean Delvare wrote:
> > > Any update? Would be great to not lose all the work that both you and
> > > me put in this driver so far.
> >
> > If you do not reply, I will do all the suggested changes myself and
> > push the driver upstream.
>
> I'm in the midst of the old '12 hours a day 'til we get this thing off to
> manufacturing' so I havent had time to do more than a cursory look at your
> changes and probably wont for a while longer. Other than a few minor style
> issues, I didnt see anything I'd take issue with, so if thats what you think is
> the right thing to do, then please do.
OK, I've written 3 patches applying on top of your work and addressing
most of the issues I had commented on. I'll post them to the list now.
I wasn't able to test them as I don't have a TMP102 chip here, so I
would appreciate if you could review the patches and/or test them as
your time permits.
--
Jean Delvare
prev parent reply other threads:[~2010-05-17 12:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-14 4:00 [PATCH v2] hwmon: driver for TI tmp102 temperature sensor Steven King
2010-03-15 12:52 ` Jean Delvare
2010-04-03 7:23 ` [lm-sensors] " Jean Delvare
2010-05-04 9:36 ` Jean Delvare
2010-05-05 15:31 ` Steven King
2010-05-17 12:20 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100517142019.36f392ad@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=sfking@fdwdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox