From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sundar R Iyer <sundar.iyer@stericsson.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
STEricsson_nomadik_linux <STEricsson_nomadik_linux@list.st.com>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Linus WALLEIJ <linus.walleij@stericsson.com>
Subject: Re: [PATCH 1/1] regulator: return set_mode is same mode is requested
Date: Mon, 17 May 2010 08:34:32 -0700 [thread overview]
Message-ID: <20100517153431.GA6218@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1274109402.20589.39.camel@bnru01>
On Mon, May 17, 2010 at 08:45:45PM +0530, Sundar R Iyer wrote:
> + /* sanity check */
> + if (!rdev->desc->ops->get_mode) {
> + ret = -EINVAL;
> + goto out;
> + }
This doesn't seem like the right error handling - if the driver has a
set_mode() you'd *expect* it to have a get_mode() but there's no need
for it to be a strict requirement.
next prev parent reply other threads:[~2010-05-17 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 14:09 [PATCH 1/1] regulator: return set_mode is same mode is requested Sundar Iyer
2010-05-17 14:35 ` Liam Girdwood
2010-05-17 14:44 ` Mark Brown
2010-05-17 14:56 ` Sundar R Iyer
2010-05-17 15:15 ` Sundar R Iyer
2010-05-17 15:34 ` Mark Brown [this message]
2010-05-17 15:54 ` Sundar R Iyer
2010-05-17 16:08 ` Mark Brown
2010-05-17 19:44 ` Liam Girdwood
2010-05-17 15:18 ` Sundar R Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100517153431.GA6218@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=sundar.iyer@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox