From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andrew Tridgell <tridge@samba.org>,
David Howells <dhowells@redhat.com>,
Eric Paris <eparis@parisplace.org>,
Jakub Jelinek <jakub@redhat.com>,
James Morris <jmorris@namei.org>,
Stephen Smalley <sds@tycho.nsa.gov>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] signals: check_kill_permission: don't check creds if same_thread_group()
Date: Mon, 17 May 2010 18:25:46 -0700 (PDT) [thread overview]
Message-ID: <20100518012547.0BE09402C2@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of Monday, 17 May 2010 21:54:14 +0200 <20100517195414.GA21504@redhat.com>
Acked-by: Roland McGrath <roland@redhat.com>
I concur that there is no real security benefit from checking uids for any
CLONE_VM case. But there is also no reason to change the old behavior in
this corner for any case but CLONE_THREAD.
Thanks,
Roland
next prev parent reply other threads:[~2010-05-18 1:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 19:54 [PATCH] signals: check_kill_permission: don't check creds if same_thread_group() Oleg Nesterov
2010-05-18 1:25 ` Roland McGrath [this message]
2010-05-18 8:55 ` David Howells
2010-05-18 13:39 ` Oleg Nesterov
2010-05-18 13:50 ` David Howells
2010-05-18 14:08 ` Oleg Nesterov
2010-05-20 19:42 ` Andrew Morton
2010-05-20 20:02 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100518012547.0BE09402C2@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=eparis@parisplace.org \
--cc=jakub@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=sds@tycho.nsa.gov \
--cc=tridge@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox