From: Robert Richter <robert.richter@amd.com>
To: "mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"eranian@google.com" <eranian@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"acme@redhat.com" <acme@redhat.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mhiramat@redhat.com" <mhiramat@redhat.com>,
"mingo@elte.hu" <mingo@elte.hu>
Cc: "linux-tip-commits@vger.kernel.org" <linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:perf/core] perf probe: Don't compile CFI related code if elfutils is old
Date: Tue, 18 May 2010 11:35:35 +0200 [thread overview]
Message-ID: <20100518093535.GF21799@erda.amd.com> (raw)
In-Reply-To: <tip-7752f1b096e13991f20b59fd11ba73da3809d93c@git.kernel.org>
On 17.05.10 21:57:38, tip-bot for Masami Hiramatsu wrote:
> Commit-ID: 7752f1b096e13991f20b59fd11ba73da3809d93c
> Gitweb: http://git.kernel.org/tip/7752f1b096e13991f20b59fd11ba73da3809d93c
> Author: Masami Hiramatsu <mhiramat@redhat.com>
> AuthorDate: Mon, 10 May 2010 13:12:07 -0400
> Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
> CommitDate: Mon, 17 May 2010 22:13:51 -0300
>
> perf probe: Don't compile CFI related code if elfutils is old
>
> Check elfutils version, and if it is old don't compile CFI analysis code. This
> allows to compile perf with old elfutils.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
> Tested-by: Stephane Eranian <eranian@google.com>
> Reported-by: Robert Richter <robert.richter@amd.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> LKML-Reference: <20100510171207.26029.97604.stgit@localhost6.localdomain6>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
I think this patch is not needed as we came up with an alternative
solution with commit:
6b3c4ef perf probe: Check older elfutils and set NO_DWARF
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com
next prev parent reply other threads:[~2010-05-18 9:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 17:12 [PATCH -tip] perf probe: Don't compile CFI related code if elfutils is old Masami Hiramatsu
2010-05-10 17:28 ` Arnaldo Carvalho de Melo
2010-05-10 18:36 ` Robert Richter
2010-05-10 18:57 ` Arnaldo Carvalho de Melo
2010-05-10 18:57 ` Masami Hiramatsu
2010-05-10 19:15 ` Arnaldo Carvalho de Melo
2010-05-10 19:19 ` Masami Hiramatsu
2010-05-11 4:59 ` [PATCH -tip] perf probe: Check older elfutils and set NO_DWARF Masami Hiramatsu
2010-05-11 10:41 ` Robert Richter
2010-05-12 8:40 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2010-05-11 8:12 ` [PATCH -tip] perf probe: Don't compile CFI related code if elfutils is old Mark Wielaard
2010-05-18 1:57 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2010-05-18 9:35 ` Robert Richter [this message]
2010-05-18 9:39 ` Stephane Eranian
2010-05-18 10:18 ` Robert Richter
2010-05-18 14:03 ` acme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100518093535.GF21799@erda.amd.com \
--to=robert.richter@amd.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).