From: Russ Anderson <rja@sgi.com>
To: Ingo Molnar <mingo@elte.hu>, Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>,
Russ Anderson <rja@sgi.com>
Subject: [BUGFIX] perf record: remove unneeded gettimeofday() call
Date: Tue, 18 May 2010 17:52:40 -0500 [thread overview]
Message-ID: <20100518225240.GC25589@sgi.com> (raw)
Perf record repeatedly calls gettimeofday() which adds noise to the performance
measurements. Since gettimeofday() is only used for the error printf,
delete it.
Signed-off-by: Russ Anderson <rja@sgi.com>
---
tools/perf/builtin-record.c | 17 +----------------
1 file changed, 1 insertion(+), 16 deletions(-)
Index: linux/tools/perf/builtin-record.c
===================================================================
--- linux.orig/tools/perf/builtin-record.c 2010-05-18 16:03:58.000000000 -0500
+++ linux/tools/perf/builtin-record.c 2010-05-18 17:28:00.765537656 -0500
@@ -64,9 +64,6 @@ static bool multiplex = false;
static int multiplex_fd = -1;
static long samples = 0;
-static struct timeval last_read;
-static struct timeval this_read;
-
static u64 bytes_written = 0;
static struct pollfd *event_array;
@@ -146,8 +143,6 @@ static void mmap_read(struct mmap_data *
void *buf;
int diff;
- gettimeofday(&this_read, NULL);
-
/*
* If we're further behind than half the buffer, there's a chance
* the writer will bite our tail and mess up the samples under us.
@@ -158,23 +153,13 @@ static void mmap_read(struct mmap_data *
*/
diff = head - old;
if (diff < 0) {
- struct timeval iv;
- unsigned long msecs;
-
- timersub(&this_read, &last_read, &iv);
- msecs = iv.tv_sec*1000 + iv.tv_usec/1000;
-
- fprintf(stderr, "WARNING: failed to keep up with mmap data."
- " Last read %lu msecs ago.\n", msecs);
-
+ fprintf(stderr, "WARNING: failed to keep up with mmap data\n");
/*
* head points to a known good entry, start there.
*/
old = head;
}
- last_read = this_read;
-
if (old != head)
samples++;
--
Russ Anderson, OS RAS/Partitioning Project Lead
SGI - Silicon Graphics Inc rja@sgi.com
next reply other threads:[~2010-05-18 22:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 22:52 Russ Anderson [this message]
2010-05-21 8:52 ` [tip:perf/core] perf record: remove unneeded gettimeofday() call tip-bot for Russ Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100518225240.GC25589@sgi.com \
--to=rja@sgi.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).