[PATCH] selinux: remove all rcu head initializations

[PATCH] selinux: remove all rcu head initializations

[Paul E. McKenney]

Hello!

Would you guys like to carry this patch, or should I push it up
-tip?  If I don't hear otherwise from you, I will push it up -tip.
The INIT_RCU_HEAD() primitive is going away in favor of debugobjects.

							Thanx, Paul

------------------------------------------------------------------------

selinux: remove all rcu head initializations

Remove all rcu head inits. We don't care about the RCU head state before passing
it to call_rcu() anyway. Only leave the "on_stack" variants so debugobjects can
keep track of objects on stack.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Stephen Smalley <sds@tycho.nsa.gov>
Reviewed-by: James Morris <jmorris@namei.org>
Cc: Eric Paris <eparis@parisplace.org>

diff --git a/security/selinux/avc.c b/security/selinux/avc.c
index 989fef8..bf4e3bc 100644
--- a/security/selinux/avc.c
+++ b/security/selinux/avc.c
@@ -288,7 +288,6 @@ static struct avc_node *avc_alloc_node(void)
 	if (!node)
 		goto out;
 
-	INIT_RCU_HEAD(&node->rhead);
 	INIT_HLIST_NODE(&node->list);
 	avc_cache_stats_incr(allocations);
 
diff --git a/security/selinux/netnode.c b/security/selinux/netnode.c
index dc92792..65ebfe9 100644
--- a/security/selinux/netnode.c
+++ b/security/selinux/netnode.c
@@ -183,8 +183,6 @@ static void sel_netnode_insert(struct sel_netnode *node)
 		BUG();
 	}
 
-	INIT_RCU_HEAD(&node->rcu);
-
 	/* we need to impose a limit on the growth of the hash table so check
 	 * this bucket to make sure it is within the specified bounds */
 	list_add_rcu(&node->list, &sel_netnode_hash[idx].list);

Re: [PATCH] selinux: remove all rcu head initializations

[James Morris]

On Tue, 18 May 2010, Paul E. McKenney wrote:

> Hello!
> 
> Would you guys like to carry this patch, or should I push it up
> -tip?  If I don't hear otherwise from you, I will push it up -tip.
> The INIT_RCU_HEAD() primitive is going away in favor of debugobjects.

Are there any prerequisites for this patch?  If not, I'll take it.


-- 
James Morris
<jmorris@namei.org>

Re: [PATCH] selinux: remove all rcu head initializations

[Paul E. McKenney]

On Wed, May 19, 2010 at 08:59:07AM +1000, James Morris wrote:
> On Tue, 18 May 2010, Paul E. McKenney wrote:
> 
> > Hello!
> > 
> > Would you guys like to carry this patch, or should I push it up
> > -tip?  If I don't hear otherwise from you, I will push it up -tip.
> > The INIT_RCU_HEAD() primitive is going away in favor of debugobjects.
> 
> Are there any prerequisites for this patch?  If not, I'll take it.

There are no prerequisites.  Please let me know when you have taken
it, and I will happily remove it from my tree.  ;-)

							Thanx, Paul

Re: [PATCH] selinux: remove all rcu head initializations

[James Morris]

On Tue, 18 May 2010, Paul E. McKenney wrote:

> Hello!
> 
> Would you guys like to carry this patch, or should I push it up
> -tip?  If I don't hear otherwise from you, I will push it up -tip.
> The INIT_RCU_HEAD() primitive is going away in favor of debugobjects.
> 

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next-queue


-- 
James Morris
<jmorris@namei.org>

Re: [PATCH] selinux: remove all rcu head initializations

[Paul E. McKenney]

On Wed, May 19, 2010 at 09:39:03AM +1000, James Morris wrote:
> On Tue, 18 May 2010, Paul E. McKenney wrote:
> 
> > Hello!
> > 
> > Would you guys like to carry this patch, or should I push it up
> > -tip?  If I don't hear otherwise from you, I will push it up -tip.
> > The INIT_RCU_HEAD() primitive is going away in favor of debugobjects.
> > 
> 
> Applied to
> git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next-queue

Thank you, I have removed it from my tree.

							Thanx, Paul