From: David Miller <davem@davemloft.net>
To: jbaron@redhat.com
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
mathieu.desnoyers@polymtl.ca, hpa@zytor.com, tglx@linutronix.de,
rostedt@goodmis.org, andi@firstfloor.org, roland@redhat.com,
rth@redhat.com, mhiramat@redhat.com, fweisbec@gmail.com,
avi@redhat.com, vgoyal@redhat.com
Subject: Re: [PATCH 07/13] jump label v8: sort jump table at build-time
Date: Wed, 19 May 2010 15:36:34 -0700 (PDT) [thread overview]
Message-ID: <20100519.153634.266077873.davem@davemloft.net> (raw)
In-Reply-To: <f9a6149e89c8c0131e1ac1fa5ea163c4f5b023d1.1274283321.git.jbaron@redhat.com>
From: Jason Baron <jbaron@redhat.com>
Date: Wed, 19 May 2010 12:22:17 -0400
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 2092361..fe6f8be 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -17,6 +17,8 @@
> #include "modpost.h"
> #include "../../include/generated/autoconf.h"
> #include "../../include/linux/license.h"
> +#include <linux/types.h>
> +#include "jump_entry.h"
>
This breaks the build on non-jump_label-supporting architectures
because only they will have the jump_entry.h header file.
I'm really getting tired trying to test your changes and every single
time as I go through doing very basic build testing I always hit one
patch that assumes jump label support exists, or assumes some x86'ism.
next prev parent reply other threads:[~2010-05-19 22:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 16:21 [PATCH 00/13] jump label v8 Jason Baron
2010-05-19 16:21 ` [PATCH 01/13] jump label v8: notifier atomic call chain notrace Jason Baron
2010-05-19 16:21 ` [PATCH 02/13] jump label v8: base patch Jason Baron
2010-05-19 16:21 ` [PATCH 03/13] jump label v8: x86 support Jason Baron
2010-05-19 16:22 ` [PATCH 04/13] jump label v8: tracepoint support Jason Baron
2010-05-19 16:22 ` [PATCH 05/13] jump label v8: add module support Jason Baron
2010-05-19 16:22 ` [PATCH 06/13] jump label v8: move ftrace_dyn_arch_init to common code Jason Baron
2010-05-19 16:22 ` [PATCH 07/13] jump label v8: sort jump table at build-time Jason Baron
2010-05-19 22:36 ` David Miller [this message]
2010-05-20 20:17 ` Jason Baron
2010-05-20 21:32 ` Mathieu Desnoyers
2010-05-24 20:14 ` Jason Baron
2010-05-20 22:24 ` David Miller
2010-05-19 16:22 ` [PATCH 08/13] jump label v8: initialize workqueue tracepoints *before* they are registered Jason Baron
2010-05-19 16:22 ` [PATCH 09/13] jump label v8: jump_label_text_reserved() to reserve our jump points Jason Baron
2010-05-19 16:22 ` [PATCH 10/13] jump label v8: add docs Jason Baron
2010-05-19 16:22 ` [PATCH 11/13] jump label v8: convert jump label to use a key Jason Baron
2010-05-19 16:22 ` [PATCH 12/13] jump label v8: convert dynamic debug to use jump labels Jason Baron
2010-05-19 16:22 ` [PATCH 13/13] jump label v8: sparc64 add jump_label support Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100519.153634.266077873.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andi@firstfloor.org \
--cc=avi@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=rostedt@goodmis.org \
--cc=rth@redhat.com \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).