From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Masami Hiramatsu <mhiramat@redhat.com>,
Mel Gorman <mel@csn.ul.ie>, Steven Rostedt <rostedt@goodmis.org>,
Randy Dunlap <rdunlap@xenotime.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Roland McGrath <roland@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Oleg Nesterov <oleg@redhat.com>, Mark Wielaard <mjw@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Jim Keniston <jkenisto@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"Frank Ch. Eigler" <fche@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH v4 0/13] Uprobes v4
Date: Wed, 19 May 2010 11:38:03 +0530 [thread overview]
Message-ID: <20100519060803.GB19957@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100518204944.GA6959@Krystal>
> * Srikar Dronamraju (srikar@linux.vnet.ibm.com) wrote:
> > Uprobes Patches
> >
> > Changelog from v3:
> > - Reverted to background page replacement as suggested by Peter Zijlstra.
>
> Why ?
>
> I'm not sure we reached any concensus about the need for a background page
> replacement.
>
> Thanks,
>
> Mathieu
>
I was tested with access_process_vm(previous patchset) and the current
(background page replacement) and the results are the same.
However Peter Zijlstra's contention still stands that we might be
relying on a undocumented feature in the hardware and the flipping the
pages isnt that hard or expensive.
Even Linus, (http://lkml.org/lkml/2010/1/27/87) had shown inclination
towards background page replacement.
Also when uprobes implements global tracing support (i.e probing a
particular symbol in a dso across processes), it has to rely on
background page replacement.
Hence I based this patchset on background page replacement rather than
on access_process_vm. Later On, if there is a consensus on using
access_process_vm, we can make the corresponding changes.
--
Thanks and Regards
Srikar
next prev parent reply other threads:[~2010-05-19 6:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 16:58 [PATCH v4 0/13] Uprobes v4 Srikar Dronamraju
2010-05-18 16:58 ` [PATCH v4 1/13] X86 instruction analysis: Move Macro W to insn.h Srikar Dronamraju
2010-05-18 16:58 ` [PATCH v4 2/13] mm: Move replace_page to mm/memory.c Srikar Dronamraju
2010-05-18 16:58 ` [PATCH v4 3/13] User Space Breakpoint Assistance Layer Srikar Dronamraju
2010-05-18 16:59 ` [PATCH v4 4/13] x86 support for User space breakpoint assistance Srikar Dronamraju
2010-05-18 16:59 ` [PATCH v4 5/13] Slot allocation for execution out of line (XOL) Srikar Dronamraju
2010-05-18 16:59 ` [PATCH v4 6/13] Uprobes Implementation Srikar Dronamraju
2010-05-18 16:59 ` [PATCH v4 7/13] x86 support for Uprobes Srikar Dronamraju
2010-05-18 16:59 ` [PATCH v4 8/13] samples: Uprobes samples Srikar Dronamraju
2010-05-18 17:00 ` [PATCH v4 9/13] Uprobes documentation Srikar Dronamraju
2010-05-18 17:00 ` [PATCH v4 10/13] trace: Common code for kprobes/uprobes traceevents Srikar Dronamraju
2010-05-18 17:23 ` Masami Hiramatsu
2010-05-19 6:21 ` Srikar Dronamraju
2010-05-19 14:44 ` Masami Hiramatsu
2010-05-18 17:00 ` [PATCH v4 11/13] trace: uprobes trace_event interface Srikar Dronamraju
2010-05-25 2:22 ` Steven Rostedt
2010-05-25 12:23 ` Srikar Dronamraju
2010-05-18 17:00 ` [PATCH v4 12/13] perf: Dont adjust symbols on name lookup Srikar Dronamraju
2010-05-18 17:00 ` [PATCH v4 13/13] perf: perf interface for uprobes Srikar Dronamraju
2010-05-18 20:49 ` [PATCH v4 0/13] Uprobes v4 Mathieu Desnoyers
2010-05-19 6:08 ` Srikar Dronamraju [this message]
2010-05-19 14:15 ` Mathieu Desnoyers
2010-05-19 14:17 ` Peter Zijlstra
2010-05-19 17:38 ` Srikar Dronamraju
2010-05-19 17:45 ` Frank Ch. Eigler
2010-05-19 17:54 ` Peter Zijlstra
2010-05-20 2:26 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100519060803.GB19957@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=fche@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=jkenisto@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mel@csn.ul.ie \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=mjw@redhat.com \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rdunlap@xenotime.net \
--cc=rjw@sisk.pl \
--cc=roland@redhat.com \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).