[PATCH] block: remove all rcu head initializations

[PATCH] block: remove all rcu head initializations

[Paul E. McKenney]

Hello, Jens,

Would you like to carry this patch, or should I push it up -tip?  If I
don't hear otherwise from you, I will push it up -tip.  The
INIT_RCU_HEAD() primitive is going away in favor of debugobjects.

							Thanx, Paul

------------------------------------------------------------------------

block: remove all rcu head initializations

Remove all rcu head inits. We don't care about the RCU head state before passing
it to call_rcu() anyway. Only leave the "on_stack" variants so debugobjects can
keep track of objects on stack.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Jens Axboe <jens.axboe@oracle.com>

diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index 5f127cf..702d006 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -3743,7 +3743,6 @@ static void *cfq_init_queue(struct request_queue *q)
 	 * second, in order to have larger depth for async operations.
 	 */
 	cfqd->last_delayed_sync = jiffies - HZ;
-	INIT_RCU_HEAD(&cfqd->rcu);
 	return cfqd;
 }
 
diff --git a/block/genhd.c b/block/genhd.c
index d13ba76..27e85a2 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -987,7 +987,6 @@ int disk_expand_part_tbl(struct gendisk *disk, int partno)
 	if (!new_ptbl)
 		return -ENOMEM;
 
-	INIT_RCU_HEAD(&new_ptbl->rcu_head);
 	new_ptbl->len = target;
 
 	for (i = 0; i < len; i++)

Re: [PATCH] block: remove all rcu head initializations

[Jens Axboe]

On Tue, May 18 2010, Paul E. McKenney wrote:
> Hello, Jens,
> 
> Would you like to carry this patch, or should I push it up -tip?  If I
> don't hear otherwise from you, I will push it up -tip.  The
> INIT_RCU_HEAD() primitive is going away in favor of debugobjects.

I'll queue it up, thanks!

-- 
Jens Axboe

Re: [PATCH] block: remove all rcu head initializations

[Paul E. McKenney]

On Wed, May 19, 2010 at 08:26:28AM +0200, Jens Axboe wrote:
> On Tue, May 18 2010, Paul E. McKenney wrote:
> > Hello, Jens,
> > 
> > Would you like to carry this patch, or should I push it up -tip?  If I
> > don't hear otherwise from you, I will push it up -tip.  The
> > INIT_RCU_HEAD() primitive is going away in favor of debugobjects.
> 
> I'll queue it up, thanks!

Let me know when you have it, and I will happily remove it from my
tree.  ;-)

							Thanx, Paul

Re: [PATCH] block: remove all rcu head initializations

[Jens Axboe]

On Wed, May 19 2010, Paul E. McKenney wrote:
> On Wed, May 19, 2010 at 08:26:28AM +0200, Jens Axboe wrote:
> > On Tue, May 18 2010, Paul E. McKenney wrote:
> > > Hello, Jens,
> > > 
> > > Would you like to carry this patch, or should I push it up -tip?  If I
> > > don't hear otherwise from you, I will push it up -tip.  The
> > > INIT_RCU_HEAD() primitive is going away in favor of debugobjects.
> > 
> > I'll queue it up, thanks!
> 
> Let me know when you have it, and I will happily remove it from my
> tree.  ;-)

It was in when I sent the email, it's queued up in for-2.6.35 :-)

-- 
Jens Axboe

Re: [PATCH] block: remove all rcu head initializations

[Paul E. McKenney]

On Wed, May 19, 2010 at 04:03:44PM +0200, Jens Axboe wrote:
> On Wed, May 19 2010, Paul E. McKenney wrote:
> > On Wed, May 19, 2010 at 08:26:28AM +0200, Jens Axboe wrote:
> > > On Tue, May 18 2010, Paul E. McKenney wrote:
> > > > Hello, Jens,
> > > > 
> > > > Would you like to carry this patch, or should I push it up -tip?  If I
> > > > don't hear otherwise from you, I will push it up -tip.  The
> > > > INIT_RCU_HEAD() primitive is going away in favor of debugobjects.
> > > 
> > > I'll queue it up, thanks!
> > 
> > Let me know when you have it, and I will happily remove it from my
> > tree.  ;-)
> 
> It was in when I sent the email, it's queued up in for-2.6.35 :-)

;-)

Very good, I have removed it from my tree.

							Thanx, Paul