From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Daniel Mack <daniel@caiaq.de>
Cc: Greg KH <gregkh@suse.de>,
linux-kernel@vger.kernel.org, kay.sievers@vrfy.org,
dwmw2@infradead.org, broonie@opensource.wolfsonmicro.com,
len.brown@intel.com, astarikovskiy@suse.de, mreimer@vpop.net,
zbr@ioremap.net, tj@kernel.org
Subject: Re: [PATCH] power/ds2760_battery: document ABI change
Date: Wed, 19 May 2010 12:34:22 +0400 [thread overview]
Message-ID: <20100519083422.GA31202@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20100518203049.GK30801@buzzloop.caiaq.de>
On Tue, May 18, 2010 at 10:30:49PM +0200, Daniel Mack wrote:
> >From 7ed6b078c1cb718509a0faf79ac53f768fa5cfc4 Mon Sep 17 00:00:00 2001
> From: Daniel Mack <daniel@caiaq.de>
> Date: Tue, 18 May 2010 22:26:40 +0200
> Subject: [PATCH] power/ds2760_battery: document ABI change
>
> Add some documentation for the newly added writeable properties.
>
I added 'Suggested-by: Greg KH <gregkh@suse.de>' tag here.
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> ---
> On Tue, May 18, 2010 at 12:56:24PM -0700, Greg KH wrote:
> > On Tue, May 18, 2010 at 09:49:52PM +0200, Daniel Mack wrote:
> > > This patch adds support for writeable power supply properties and
> > > exposes them as writeable to sysfs.
> >
> > Please properly document this in Documentation/ABI as you are changing
> > the userspace ABI.
> >
> > thanks,
> >
> > greg k-h
>
> Is something like the following appropriate?
Looks good to me, as well as patches 1-3 (though in the first patch
I fixed power_supply_attr_groups to be static, it was a negligence
from my original patch).
I applied all these patches to battery-2.6.git, thanks!
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2010-05-19 8:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 16:38 [PATCH 1/3] pda_power: add support for writeable properties Daniel Mack
2010-05-11 16:38 ` [PATCH 2/3] power/ds2760_battery: make charge_now and charge_full writeable Daniel Mack
2010-05-11 16:44 ` Daniel Mack
2010-05-11 17:20 ` Anton Vorontsov
2010-05-11 17:28 ` Daniel Mack
2010-05-11 18:05 ` Anton Vorontsov
2010-05-18 18:24 ` Daniel Mack
2010-05-11 16:38 ` [PATCH 3/3] power/ds2760_battery: use factor of 20 for rated_capacity Daniel Mack
2010-05-11 17:19 ` Anton Vorontsov
2010-05-11 17:25 ` Daniel Mack
2010-05-11 17:47 ` Anton Vorontsov
2010-05-11 17:47 ` [PATCH 1/3] pda_power: add support for writeable properties Anton Vorontsov
2010-05-11 17:58 ` Daniel Mack
2010-05-11 18:23 ` Anton Vorontsov
2010-05-11 22:28 ` Daniel Mack
2010-05-12 18:15 ` [PATCH] Introduce {sysfs,device}_create_file_mode Anton Vorontsov
2010-05-12 18:18 ` Daniel Mack
2010-05-12 18:38 ` Greg KH
2010-05-12 19:08 ` Anton Vorontsov
2010-05-12 19:12 ` Kay Sievers
2010-05-12 19:19 ` Greg KH
2010-05-12 19:39 ` Anton Vorontsov
2010-05-12 19:30 ` Anton Vorontsov
2010-05-13 9:33 ` Daniel Mack
2010-05-17 19:40 ` [PATCH] power_supply: Use attribute groups Anton Vorontsov
2010-05-18 17:35 ` Daniel Mack
2010-05-18 19:49 ` [PATCH 1/3] " Daniel Mack
2010-05-18 19:49 ` [PATCH 2/3] pda_power: add support for writeable properties Daniel Mack
2010-05-18 19:56 ` Greg KH
2010-05-18 20:30 ` [PATCH] power/ds2760_battery: document ABI change Daniel Mack
2010-05-19 8:34 ` Anton Vorontsov [this message]
2010-05-18 19:49 ` [PATCH 3/3] power/ds2760_battery: make charge_now and charge_full writeable Daniel Mack
2010-05-11 18:32 ` [PATCH 1/3] pda_power: add support for writeable properties Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100519083422.GA31202@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=astarikovskiy@suse.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=daniel@caiaq.de \
--cc=dwmw2@infradead.org \
--cc=gregkh@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mreimer@vpop.net \
--cc=tj@kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).