From: Randy Dunlap <randy.dunlap@oracle.com>
To: "David Dajun Chen" <Dajun.Chen@diasemi.com>
Cc: <linux-kernel@vger.kernel.org>, <sameo@linux.intel.com>
Subject: Re: [PATCH] MFD of DA9052 Linux device drivers (1/9)
Date: Wed, 19 May 2010 10:13:27 -0700 [thread overview]
Message-ID: <20100519101327.b57d253b.randy.dunlap@oracle.com> (raw)
In-Reply-To: <3495EC08FA53E94AAA00CC4743D5BA7E010C20EB@pandora.diasemi.com>
On Wed, 19 May 2010 10:16:10 +0100 David Dajun Chen wrote:
Hi,
2 comments from a quick scan:
> diff -Naur linux-2.6.33.2/drivers/mfd/Kconfig linux-2.6.33.2_patch/drivers/mfd/Kconfig
> --- linux-2.6.33.2/drivers/mfd/Kconfig 2010-04-02 04:02:33.000000000 +0500
> +++ linux-2.6.33.2_patch/drivers/mfd/Kconfig 2010-05-18 15:30:37.000000000 +0500
> @@ -348,6 +348,35 @@
> read/write functions for the devices to get access to this chip.
> This chip embeds various other multimedia funtionalities as well.
>
> +config MFD_DA9052
> + bool "Dialog Semiconductor DA9052 PMIC Support"
a. why are all of these drivers "bool" (y/n) instead of tristate (y/m/n)?
i.e., why are they not buildable as loadable modules?
> + help
> + Say yes here to support for Dialog semiconductor Da9052, Power
> + Management IC.This option enables the SPI/I2C, EH, and ADC
> + features of DA9052.
> +choice
> + prompt "DA9052 SSC support"
> + depends on MFD_DA9052
> +config MFD_DA9052_SPI
> + bool "SPI"
> + select SPI
> + select GPIOLIB
> + help
> + Say Y to select SPI serial interface for DA9052 chip
> +
> +config MFD_DA9052_I2C
> + bool "I2C"
> + select I2C
> + help
> + Say Y to select I2C serial interface for DA9052 chip
> +endchoice
> +
> +config DA9052_ADC_ENABLE
> + bool "Dialog Semiconductor DA9052 ADC Driver"
> + depends on MFD_DA9052
> + help
> + Say Y to enable the ADC driver for the DA9052 chip
> +
> endmenu
>
> menu "Multimedia Capabilities Port drivers"
b. The .c and .h files have lots of comments in them that begin with "/**",
which in kernel-land means kernel-doc notation... but they are not in kernel-doc
notation. Please see Documentation/kernel-doc-nano-HOWTO.txt for info on how
to use kernel-doc notation.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-05-19 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 9:16 [PATCH] MFD of DA9052 Linux device drivers (1/9) David Dajun Chen
2010-05-19 10:15 ` Jonathan Cameron
2010-05-19 11:13 ` Alan Cox
2010-05-19 11:21 ` Jonathan Cameron
2010-05-19 17:13 ` Randy Dunlap [this message]
2010-05-21 0:06 ` Mark Brown
[not found] <F56EA673D3E56E48804FE2B0D23EFD2D217420461E@KCINPUNHJCMS01.kpit.com>
2010-06-09 11:34 ` Vijay R. Iyengar
2010-06-09 12:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100519101327.b57d253b.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=Dajun.Chen@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).