public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <daniel@zonque.org>
To: linux-kernel@vger.kernel.org
Cc: David Brownell <dbrownell@users.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Paul Mundt <lethal@linux-sh.org>, Magnus Damm <damm@igel.co.jp>,
	Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>,
	Andrea Gelmini <andrea.gelmini@gelma.net>,
	linux-usb@vger.kernel.org
Subject: drivers/usb/gadget/r8a66597-udc.h:139: warning: ‘data’ may be used uninitialized in this function
Date: Wed, 19 May 2010 13:00:30 +0200	[thread overview]
Message-ID: <20100519110030.GG30804@buzzloop.caiaq.de> (raw)

Hi,

I stumbled over the r8a66597 UDC gadget driver as the the compiler
complained about the static inline function r8a66597_read():

drivers/usb/gadget/r8a66597-udc.c: In function ‘irq_packet_read’:
drivers/usb/gadget/r8a66597-udc.h:139: warning: ‘data’ may be used uninitialized in this function
drivers/usb/gadget/r8a66597-udc.h:139: note: ‘data’ was declared here

I know nothing about the code, but this function indeed looks bogus. Can
anyone have a look at this? Also, I wonder whether this function is
actually too big for a static inline.

Thanks,
Daniel


                 reply	other threads:[~2010-05-19 11:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100519110030.GG30804@buzzloop.caiaq.de \
    --to=daniel@zonque.org \
    --cc=andrea.gelmini@gelma.net \
    --cc=damm@igel.co.jp \
    --cc=dbrownell@users.sourceforge.net \
    --cc=gregkh@suse.de \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=shimoda.yoshihiro@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox