From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: David Dajun Chen <Dajun.Chen@diasemi.com>
Cc: linux-kernel@vger.kernel.org, Michael Buesch <mb@bu3sch.de>
Subject: Re: [PATCH] GPIO of DA9052 Linux device drivers (2/9)
Date: Thu, 20 May 2010 17:23:33 +0100 [thread overview]
Message-ID: <20100520162333.GA3597@sirena.org.uk> (raw)
In-Reply-To: <3495EC08FA53E94AAA00CC4743D5BA7E010C20EF@pandora.diasemi.com>
On Wed, May 19, 2010 at 10:28:22AM +0100, David Dajun Chen wrote:
> The attached is the GPIO part of the device drivers newly developed for DA9052 Power Management IC from Dialog Semiconductor.
While there is some gpiolib functionality in this code there is also
substantial additional functionality implementing non-stnadard APIs
which appear to mostly replicate existing kernel functionality. As I
said in reply to the regulator driver I'd strongly suggest comparing the
driver with other drivers for similar devices and if you're producing
something that looks substantially different to those drivers really
reexamining in detail why your driver is different and if it should be.
next prev parent reply other threads:[~2010-05-20 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 9:28 [PATCH] GPIO of DA9052 Linux device drivers (2/9) David Dajun Chen
2010-05-20 16:23 ` Mark Brown [this message]
2010-05-20 17:55 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100520162333.GA3597@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Dajun.Chen@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox