From: Thomas Renninger <trenn@suse.de>
To: Mike Chan <mike@android.com>
Cc: menage@google.com, balbir@in.ibm.com, cpufreq@vger.kernel.org,
linux-kernel@vger.kernel.org, khilman@deeprootsystems.com,
linux-omap@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2 0/3] Enable CPU frequency and power tracking in cpuacct cgroup
Date: Thu, 20 May 2010 23:01:11 +0200 [thread overview]
Message-ID: <201005202301.12259.trenn@suse.de> (raw)
In-Reply-To: <1274380944-20947-1-git-send-email-mike@android.com>
Hi Mike,
On Thursday 20 May 2010 08:42:21 pm Mike Chan wrote:
> v2:
> Rebased off of Thomas Renninger's patch for cgroups_cpuacct refactoring,
thanks.
A general comment:
I don't know much about the cgroup stuff.
I am also not sure how exactly power can be measured on this arch based on
frequency accounting (there also were some threads I was not aware of?)
A signed-off-by or reviewed-by from someone who is more involved in this omap
stuff would probably not that bad.
Still I Iike this interface and I could imagine others hook into it as well,
for whatever has to be cpu cgroup accounted.
My two cents...,
Thomas
next prev parent reply other threads:[~2010-05-20 21:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 18:42 [PATCH v2 0/3] Enable CPU frequency and power tracking in cpuacct cgroup Mike Chan
2010-05-20 18:42 ` [PATCH v2 1/3] scheduler: cpuacct: Enable platform hooks to track cpuusage for CPU frequencies Mike Chan
2010-05-20 18:42 ` [PATCH v2 2/3] scheduler: cpuacct: Enable platform callbacks for cpuacct power tracking Mike Chan
2010-05-20 18:42 ` [PATCH v2 3/3] omap: cpu: Implement callbacks for cpu frequency tracking in cpuacct Mike Chan
2010-05-20 21:01 ` Thomas Renninger [this message]
2010-05-20 21:21 ` [PATCH v2 0/3] Enable CPU frequency and power tracking in cpuacct cgroup Mike Chan
2010-05-21 17:05 ` Kevin Hilman
2010-06-01 20:56 ` Mike Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005202301.12259.trenn@suse.de \
--to=trenn@suse.de \
--cc=balbir@in.ibm.com \
--cc=cpufreq@vger.kernel.org \
--cc=khilman@deeprootsystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=menage@google.com \
--cc=mike@android.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).