Re: [PATCH 7/8] x86/mrst: add vrtc driver which serves as a wall clock device

Joe Perches
2010-05-07T19:06:31Z

On Fri, 2010-05-07 at 20:02 +0100, Alan Cox wrote:
> On Fri, 07 May 2010 11:51:06 -0700
> Joe Perches <joe@perches.com> wrote:
> > On Fri, 2010-05-07 at 10:41 -0700, Jacob Pan wrote:
> > > + printk(KERN_INFO "vRTC: sec: %d min: %d hour: %d day: %d "
> > > + "mon: %d year: %d\n", sec, min, hour, mday, mon, year);
> > Even though many of the rtc drivers print this way, it seems
> > a very backwards way of presenting time to me.
> Consistency is really more important here IMHO - lots of drivers have set
> an existing policy.

(added Alessandro Zummo to cc's)

look at drivers/rtc.

All of them seem to use a templated copy/paste dev_dbg,
which seems to point to a use for a possible common rtc_util.c
or some such where this could be standardized.

Is there somewhere else this style is used?