Re: [PATCH 7/8] x86/mrst: add vrtc driver which serves as a wall clock device

Feng Tang
2010-05-10T09:05:59Z

On Sat, 8 May 2010 03:56:09 +0800
"H. Peter Anvin" <hpa@zytor.com> wrote:

> >
>
> Probably the right thing to do is to (a) move all this printing to
> common code; (b) change to ISO 8601 format.
>
> -hpa
>

Thank you all for the comments. please review this follow-on patch.

- Feng
--
diff --git a/arch/x86/kernel/vrtc.c b/arch/x86/kernel/vrtc.c
index fa1eb63..0fbd74d 100644
--- a/arch/x86/kernel/vrtc.c
+++ b/arch/x86/kernel/vrtc.c
@@ -74,8 +74,8 @@ unsigned long vrtc_get_time(void)
/* vRTC YEAR reg contains the offset to 1960 */
year += 1960;

- printk(KERN_INFO "vRTC: sec: %d min: %d hour: %d day: %d "
- "mon: %d year: %d\n", sec, min, hour, mday, mon, year);
+ pr_debug("vrtc time: %4d-%02d-%02d %02d:%02d:%02d\n",
+ year, mon, mday, hour, min, sec);

return mktime(year, mon, mday, hour, min, sec);
}