Re: [PATCH 7/8] x86/mrst: add vrtc driver which serves as a wall clock device

Feng Tang
2010-05-11T02:18:55Z

On Tue, 11 May 2010 02:22:15 +0800
"H. Peter Anvin" <hpa@zytor.com> wrote:

> On 05/10/2010 02:17 AM, Feng Tang wrote:
> >
> > Thank you all for the comments. please review this follow-on patch.
> >
> > - Feng
>
> That doesn't move it to common code, though. I'd rather see existing
> common style used, then merged (centralized) and *then* the style
> corrected.
>
> -hpa

Hi Peter,

The reason I didn't move it to rtc common code is, this vrtc.c sits in
arch/x86/kernel/ and better not to depend on drivers/rtc, as drivers/rtc
may not be always enabled in kernel configuration.

I also have another general driver for vrtc which will be in drivers/rtc/,
just like general x86 kernel which has a rtc.c in arch/ and a rtc-cmos.c
in drivers/rtc, I will clean my code up and try to move these funcs to a
common code.

Thanks,
Feng