public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 0/4] perf: Precise task / softirq / hardirq filtered stats/profiles
Date: Fri, 21 May 2010 17:12:30 +0200	[thread overview]
Message-ID: <20100521151230.GA20941@elte.hu> (raw)
In-Reply-To: <1274450715-23955-1-git-send-regression-fweisbec@gmail.com>


* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> Hi,
> 
> The new task and irq exclusion handling can let you 
> confine tracing and profiling to about everything you 
> want.

I fixed the subject line ;-)

'exclusion' is the ABI detail. The feature your patches 
implement are to allow 'softirq limited' or 'task-context 
limited' or 'hardirq profiling' - which is way cool.

One thing i'd like to see in this feature is for it to 
work on pure event counting - i.e. 'perf stat' as well.

This would allow some _very_ precise stats, without IRQ 
noise. For example, today we have this kind of noise
in instruction counting:


 $ for ((i=0;i<10;i++)); do perf stat -e instructions /bin/true 2>&1 | grep instructions; done
             217161  instructions             #      0,000 IPC  
             218591  instructions             #      0,000 IPC  
             223268  instructions             #      0,000 IPC  
             217112  instructions             #      0,000 IPC  
             219392  instructions             #      0,000 IPC  
             216801  instructions             #      0,000 IPC  
             217501  instructions             #      0,000 IPC  
             218565  instructions             #      0,000 IPC  
             218682  instructions             #      0,000 IPC  
             218523  instructions             #      0,000 IPC  

it it's all that bad at ~2% jitter, but many improvements 
we are working on in the kernel are much smaller than 1%.

If we extended your feature to perf stat, we might be able 
to get a lot more precise measurements in terms of kernel 
optimizations (and kernel bloat).

I'm really curious how accurate your scheme could become 
that way. From the above 'few thousands instructions' 
noise we might be able to get down to a 'hundreds of 
instructions' noise? If so then it would allow us to 
measure micro-optimizations in a radically more precise 
way.

Thanks,

	Ingo

  parent reply	other threads:[~2010-05-21 15:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-21 14:05 [PATCH 0/4] perf: Tasks and irq exclusion Frederic Weisbecker
2010-05-21 14:05 ` [PATCH 1/4] irq: Support to compute context on top of a given preempt_count offset Frederic Weisbecker
2010-05-21 14:05 ` [PATCH 2/4] perf: Add exclude_task perf event attribute Frederic Weisbecker
2010-05-25  1:43   ` Paul Mackerras
2010-05-25  6:58     ` Peter Zijlstra
2010-05-25 10:06       ` Frederic Weisbecker
2010-06-07  1:38       ` Frederic Weisbecker
2010-06-08 18:59         ` Ingo Molnar
2010-06-08 19:02           ` Frederic Weisbecker
2010-05-21 14:05 ` [PATCH 3/4] perf: Support for irq exclusion Frederic Weisbecker
2010-05-21 14:06   ` Frederic Weisbecker
2010-05-21 14:05 ` [PATCH 4/4] perf: Support for task/softirq/hardirq exclusion on tools Frederic Weisbecker
2010-05-21 15:12 ` Ingo Molnar [this message]
2010-05-21 16:15   ` [PATCH 0/4] perf: Precise task / softirq / hardirq filtered stats/profiles Peter Zijlstra
2010-05-21 18:36     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100521151230.GA20941@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox