public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Charles Clément" <caratorn@gmail.com>
To: Timofey Trofimov <tumoxep@gmail.com>
Cc: gregkh@suse.de, lieb@canonical.com, more.andres@gmail.com,
	forest@alittletooquiet.net, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: vt6656: fix brace coding style issue in 80211mgr.c This is a patch to the 80211mgr.c file that fixes up a brace warning found by the checkpatch.pl tool Signed-off-by: Timofey Trofimov <tumoxep@gmail.com>
Date: Sat, 22 May 2010 10:35:12 -0700	[thread overview]
Message-ID: <20100522173510.GA26310@fujitsu> (raw)
In-Reply-To: <1274546574-8338-1-git-send-email-tumoxep@gmail.com>

Hello Timofey,

I think the message you send should have the Signed-off-by in the body,
as well as the long description of the patch.

On Sat, May 22, 2010 at 08:42:54PM +0400, Timofey Trofimov wrote:
> ---
>  drivers/staging/vt6656/80211mgr.c |  514 ++++++++++++++++++-------------------
>  1 files changed, 251 insertions(+), 263 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/80211mgr.c b/drivers/staging/vt6656/80211mgr.c
> index f24dc55..7236019 100644
> --- a/drivers/staging/vt6656/80211mgr.c
> +++ b/drivers/staging/vt6656/80211mgr.c
> @@ -67,8 +67,8 @@
>  
>  /*---------------------  Static Variables  --------------------------*/
>  
> -static int          msglevel                =MSG_LEVEL_INFO;
> -//static int          msglevel                =MSG_LEVEL_DEBUG;
> +static int          msglevel                = MSG_LEVEL_INFO;
> +/*static int          msglevel                =MSG_LEVEL_DEBUG;*/
>  /*---------------------  Static Functions  --------------------------*/

Here, even if the code is commented you could add the extra space, in
case the code is uncommented later.

Charles.

  reply	other threads:[~2010-05-22 17:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-22 16:42 [PATCH] Staging: vt6656: fix brace coding style issue in 80211mgr.c This is a patch to the 80211mgr.c file that fixes up a brace warning found by the checkpatch.pl tool Signed-off-by: Timofey Trofimov <tumoxep@gmail.com> Timofey Trofimov
2010-05-22 17:35 ` Charles Clément [this message]
     [not found]   ` <AANLkTilS9UjF6jbsqtsZBlTkv_s4ayfu5GfW5_51tOzT@mail.gmail.com>
2010-05-22 23:53     ` Charles Clément
2010-05-24 18:42       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100522173510.GA26310@fujitsu \
    --to=caratorn@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@suse.de \
    --cc=lieb@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=more.andres@gmail.com \
    --cc=tumoxep@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox