From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755528Ab0EWWQY (ORCPT ); Sun, 23 May 2010 18:16:24 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:38084 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754571Ab0EWWQX (ORCPT ); Sun, 23 May 2010 18:16:23 -0400 Date: Sun, 23 May 2010 15:15:40 -0700 From: Randy Dunlap To: Stephen Rothwell , platform-driver-x86@vger.kernel.org Cc: linux-next@vger.kernel.org, LKML , Thadeu Lima de Souza Cascardo , Daniel Oliveira Nascimento , Matthew Garrett Subject: [PATCH -next] x86/platform: classmate-laptop depends on RFKILL Message-Id: <20100523151540.68e67298.randy.dunlap@oracle.com> In-Reply-To: <20100522170459.4c89723d.sfr@canb.auug.org.au> References: <20100522170459.4c89723d.sfr@canb.auug.org.au> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Auth-Type: Internal IP X-Source-IP: rcsinet15.oracle.com [148.87.113.117] X-CT-RefId: str=0001.0A090208.4BF9A928.00F3:SCFMA4539811,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap classmate-laptop uses rfkill interfaces, so it should depend on RFKILL. Otherwise, when CONFIG_RFKILL=m, these build errors happen: classmate-laptop.c:(.text+0x54b4f2): undefined reference to `rfkill_unregister' classmate-laptop.c:(.text+0x54b508): undefined reference to `rfkill_destroy' classmate-laptop.c:(.text+0x54b71a): undefined reference to `rfkill_alloc' classmate-laptop.c:(.text+0x54b739): undefined reference to `rfkill_register' classmate-laptop.c:(.text+0x54b761): undefined reference to `rfkill_destroy' classmate-laptop.c:(.text+0x54b841): undefined reference to `rfkill_set_sw_state' Signed-off-by: Randy Dunlap Cc: Thadeu Lima de Souza Cascardo Cc: Daniel Oliveira Nascimento Cc: platform-driver-x86@vger.kernel.org Cc: Matthew Garrett --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) --- linux-next-20100522.orig/drivers/platform/x86/Kconfig +++ linux-next-20100522/drivers/platform/x86/Kconfig @@ -520,6 +520,7 @@ config TOSHIBA_BT_RFKILL config ACPI_CMPC tristate "CMPC Laptop Extras" depends on X86 && ACPI + depends on RFKILL select INPUT select BACKLIGHT_CLASS_DEVICE default n